Fix assembly dependencies resolver for .NET Core #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this. Seems this fix will unblock other changes (net 8 fix). |
rprouse
changed the title
|
We are trying to figure out if this change might have broken some of our tests. The scenario is that we have an assembly that dual targets net472 and net6.0. It references System.Text.Json 7.0.2. When we execute the tests with the new engine containing those fixes it seems to load System.Text.Json of .NET 6 instead of 7.0.2 (the explicit reference). This issue only occurs on NET6 on Linux but not on Windows. // cc @mauroservienti |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on discussion from here: #1311