Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.4.0 causes missing method exception for System.Text.Json #1325

Closed
gregsdennis opened this issue Mar 1, 2023 · 7 comments
Closed

v4.4.0 causes missing method exception for System.Text.Json #1325

gregsdennis opened this issue Mar 1, 2023 · 7 comments
Assignees
Milestone

Comments

@gregsdennis
Copy link

gregsdennis commented Mar 1, 2023

Originally reported here.

Minimally reproducible example:
TestProject1.zip

Error occurs when the test project runs in a .Net version prior to 7.0 and references a .Net Standard 2 project that contains a reference to System.Text.Json Nuget package v7.

Example solution contains:

  • ClassLibrary1 - netstandard2.0
    • references System.Text.Json Nuget package v7
  • TestProject1 - netcoreapp3.1;net6.0;net7.0
    • references NUnit3TestAdapter v4.3.1
    • references ClassLibrary1
    • passes all tests
  • TestProject2 - netcoreapp3.1;net6.0;net7.0
    • references NUnit3TestAdapter v4.4.0
    • references ClassLibrary1
    • passes net7.0, fails netcoreapp3.1 & net6.0

Note that this also occurs referencing System.Text.Json Nuget package v6.*.

@SimonCropp
Copy link

can u try 4.4.2

@gregsdennis
Copy link
Author

gregsdennis commented Mar 1, 2023

Yeah, 4.4.2 seems to work.

It's a really weird bug though. If you have an explanation as to what's going on, I'd love to read about it.

I'd also recommend unlisting 4.4.0.

@SimonCropp
Copy link

@gregsdennis nunit/nunit3-vs-adapter#1066

and i already suggested unlisting nunit/nunit3-vs-adapter#1066 (comment) but not my call

@OsirisTerje
Copy link
Member

OsirisTerje commented Mar 2, 2023

@gregsdennis More details here https://docs.nunit.org/articles/vs-test-adapter/AdapterV4-Release-Notes.html and in the four issues whereas the one @SimonCropp mentioned is one of those.
The underlying cause is in the NUnit.Engine 3.16.3 (and ...2) , see #1324 . The fix in the adapter was to use a private build of 3.15.2 enhanced with the .net 8 code, so a pre-release of a 3.15.3 version.

And, v 4.4.0 is now unlisted.

@OsirisTerje
Copy link
Member

OsirisTerje commented Mar 2, 2023

Since this issue contains a repro project (thanks @gregsdennis ), I'll move it to the console/engine repo so that it can be used with the #1324 issue there.

@CharliePoole
Copy link
Collaborator

Working in the latest dev build: 3.18.3-dev00011

@CharliePoole CharliePoole added this to the 3.18.3 milestone Oct 5, 2024
@CharliePoole
Copy link
Collaborator

This issue has been resolved in version 3.18.3

The release is available on:
GitHub.
NuGet packages are also available NuGet.org and
Chocolatey Packages may be found at Chocolatey.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants