Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade our .Net 7.0 assemblies to RC 2 #1243

Closed
CharliePoole opened this issue Oct 16, 2022 · 4 comments
Closed

Upgrade our .Net 7.0 assemblies to RC 2 #1243

CharliePoole opened this issue Oct 16, 2022 · 4 comments

Comments

@CharliePoole
Copy link
Collaborator

We're currently using RC 1

@CharliePoole
Copy link
Collaborator Author

@nunit/engine-team In order to make this work, I had to force use of the preview version of MsBuild even though a non-preview version was available.

As a refresher for everyone, the cake code was modified earlier this year by @manfred-brands so that a preview version was used IFF no non-preview version was installed. This doesn't work either on my machine or in any of our CI environments because both the stable and preview versions of VS 2022 are installed. (On my own machine, VS2019 is installed as well.)

Consequently, the current code will always use a preview version, if it is higher than any non-preview versions. That's OK right now with .NET 7.0.0-rc2 but isn't guaranteed to be the right choice all the time in the future. Folks could have a preview installed for some other reason and not want it to be used to build the engine.

I'm thinking that some kind of command option to the build script is needed, either to cause use of a preview or to suppress it. The default should be whichever option we think would be most common. Any thoughts on this?

@CharliePoole
Copy link
Collaborator Author

Ah! I spoke too soon. That doesn't work on AppVeyor because the newer version of MSBuild is not installed with Visual Studio, but separately as part of the SDK.

However, the general question of use of preview versions still stands.

@CharliePoole
Copy link
Collaborator Author

Available on our myget feed as version 3.16.0-dev00048

@CharliePoole CharliePoole self-assigned this Oct 29, 2022
@CharliePoole
Copy link
Collaborator Author

This issue has been resolved in version 3.16.0

The release is available on:
GitHub.
NuGet packages are also available NuGet.org and
Chocolatey Packages may be found at Chocolatey.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant