-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change name of NUnit Net Core Runner executable #1224
Comments
I don't have a strong opinion on this. Do you know of any tools like Cake that would need to be updated to work with the new name? |
@rprouse Only that the scripts will need to be updated. I think most links get forwarded but I'll do more research. |
@CharliePoole I think the name is fine, and I think it makes sense to change the name even if it is a breaking change. If it is mentioned explicitly in the release notes, then I think people can adapt to it. |
@mikkelbu @rprouse In that case, I think I'll go ahead and do it. @rprouse Thinking more about your question, I realized that the cake extensions similar to the one you maintain would need to be updated, but only if they use the .NET Core runner. I don't know of any that do that. Also, we can keep the dotnet CLI command the same. |
This issue has been resolved in version 3.16.0 The release is available on: |
@rprouse @mikkelbu @jnm2 @nunit/engine-team @nunit/framework-team
Strictly speaking, this would be a breaking change and should not be done in 3.16.
However, I have had so much confusion in issues between people using the two different runners, with entirely different feature sets, both called
nunit3-console.exe
. That it's tempting to do it without waiting for 4.0. I'm thinking of calling itnunit-netcore-console.exe
.This would break interactive usage as well as use of the runner in scripts... i.e.
.\net6.0\nunit3-console.exe
would need changing.Since I'm proposing this primarily for my own convenience in handling bug reports, I'll accept the result of a vote. :-)
The text was updated successfully, but these errors were encountered: