Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize build output (bin) directories #1118

Closed
Tracked by #1258
CharliePoole opened this issue Jan 28, 2022 · 3 comments
Closed
Tracked by #1258

Reorganize build output (bin) directories #1118

CharliePoole opened this issue Jan 28, 2022 · 3 comments
Assignees
Milestone

Comments

@CharliePoole
Copy link
Collaborator

Currently we build into a set of bin directories according to the target runtime... net20, netcoreapp3.1, etc. Then we Publish the projects into the same directories. This can be very confusing to debug because it's not always obvious whether a problem has arisen in the build step or the publish step.

Since we do now publish all the binaries to BIN_DIR, I'm proposing that we go back to the naive build approach of having a bin directory under each project. We can then continue to publish them to the main bin directory (BIN_DIR) and that published structure does not have to match the existing one. Rather it can be made to look pretty much like the structure we want in our packages allowing further simplification.

@rprouse @mikkelbu @jnm2
I'd appreciate comments on this idea before I do it.

@mikkelbu
Copy link
Member

mikkelbu commented Feb 3, 2022

Given the confusion in #1044 I think it is fine to separate them

@CharliePoole CharliePoole modified the milestones: 3.16.0, 4.0 Feb 3, 2022
@CharliePoole
Copy link
Collaborator Author

Changes in the 3.15.0 release have simplified the publishing step substantially. I'm moving this to 4.0 for further investigation.

@CharliePoole CharliePoole self-assigned this Oct 13, 2022
@CharliePoole CharliePoole modified the milestones: 4.0, 3.16 Oct 13, 2022
@CharliePoole CharliePoole added the PortToVersion4 Version 3 change needs to be ported to the version 4 code in main label Oct 31, 2022
@CharliePoole
Copy link
Collaborator Author

This issue has been resolved in version 3.16.0

The release is available on:
GitHub.
NuGet packages are also available NuGet.org and
Chocolatey Packages may be found at Chocolatey.org

@CharliePoole CharliePoole removed the PortToVersion4 Version 3 change needs to be ported to the version 4 code in main label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants