Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filesystem walker should be configurable in config #394

Closed
ratorx opened this issue Aug 23, 2024 · 2 comments
Closed

Filesystem walker should be configurable in config #394

ratorx opened this issue Aug 23, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ratorx
Copy link

ratorx commented Aug 23, 2024

Is your feature request related to a problem? Please describe.

Git walker is opted in by default within a git repository with no way to opt-out without specifying the CLI arg with every invocation. This is undesirable as the git walker is not necessarily better.

The git formatter ignores untracked files by default, which is undesirable for me because I often create new files with sloppy formatting expecting the formatter to clean up before modifying it more. Having to leave the context and run the command to add the file to git is annoying.

The filesystem formatter is clearly better for my usecase, but right now I have to opt-in to it for every command, just because I am using git for version control. I think the conflict is in the assumption that "git used for version control => only format staged or tracked files".

Describe the solution you'd like

Include untracked files when using the git formatter (configurable), or allow the walker to be overridden in config.

@ratorx ratorx added the enhancement New feature or request label Aug 23, 2024
@brianmcgee brianmcgee self-assigned this Aug 23, 2024
@brianmcgee
Copy link
Member

Related to / duplicate of #351.

I have time next week to knock out some low-hanging fruit, and this will be one of them.

@ratorx ratorx closed this as completed Aug 25, 2024
@ratorx ratorx closed this as not planned Won't fix, can't repro, duplicate, stale Aug 25, 2024
@ratorx ratorx reopened this Aug 25, 2024
@ratorx
Copy link
Author

ratorx commented Aug 25, 2024

Thanks, I think that feature would completely fix my use case.

Duplicate of #351

@ratorx ratorx closed this as not planned Won't fix, can't repro, duplicate, stale Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants