You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on #668, I noticed again that the Makefile's serve rule calls git submodule update. Since the https://github.com/scientific-python/scientific-python-hugo-theme repo is a submodule in the numpy.org and scientific-python.org repos, this makes it a bit more difficult to test theme changes against these sites, because calling make serve tries to set the theme submodules back to what the "superproject" (in git-submodule terms) expects, rather than what the theme developer may have temporarily checked out in the submodule repository.
Both the numpy.org and scientific-python.org repos' Makefiles have a serve-dev rule. In each one, the only difference from the serve rule is that it adds the argument --disableFastRender (which is a Hugo option that affects how it serves the pages locally). I wonder if it would be appropriate to also use the serve-dev rule to not force the submodules to be updated; rather, we could just print a warning if the submodules aren't what's expected. This would allow the theme developer to use a different checkout in the submodule more easily.
Please let me know what you think about this idea. If it sounds good, I'll update the Makefiles accordingly. Thanks.
# Serve for development purposes (without the "prepare" step, which# updates submodules. Also, use --poll to workaround# <https://github.com/gohugoio/hugo/issues/10893>).# TODO: Make this rule common among related projects' Makefiles.serve-dev:
hugo --printI18nWarnings server --disableFastRender --poll 1000ms
@jarrodmillman @stefanv
While working on #668, I noticed again that the Makefile's
serve
rule callsgit submodule update
. Since the https://github.com/scientific-python/scientific-python-hugo-theme repo is a submodule in the numpy.org and scientific-python.org repos, this makes it a bit more difficult to test theme changes against these sites, because callingmake serve
tries to set the theme submodules back to what the "superproject" (in git-submodule terms) expects, rather than what the theme developer may have temporarily checked out in the submodule repository.Both the numpy.org and scientific-python.org repos' Makefiles have a
serve-dev
rule. In each one, the only difference from theserve
rule is that it adds the argument--disableFastRender
(which is a Hugo option that affects how it serves the pages locally). I wonder if it would be appropriate to also use theserve-dev
rule to not force the submodules to be updated; rather, we could just print a warning if the submodules aren't what's expected. This would allow the theme developer to use a different checkout in the submodule more easily.Please let me know what you think about this idea. If it sounds good, I'll update the Makefiles accordingly. Thanks.
See also: #526
The text was updated successfully, but these errors were encountered: