-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Padding for translated text in top-page cards #417
Comments
I'm not sure if there's a better solution than "use as much whitespace as the most verbose language needs". @joelachance any other ideas? |
More examples/info here: https://css-tricks.com/snippets/css/truncate-string-with-ellipsis/ |
Great idea @joelachance! I think for box titles it may look a little odd and we should increase the space a bit to make things fit (if every 3-4 word title has the last word replaced by |
@rgommers, I agree about the titles, we should definitely increase padding/margin there. I also like the fade out for the main content in these cells, good find! |
Thanks! |
Looks good to me! @melissawm what do you think? PR preview will show en/pt/ja so it'll be easy to compare. |
PR above! |
Left my review in the PR - looks great to me, thanks! |
Similar to #416: translated (portuguese) text in the cards takes up more space than expected. Row 1, column 2 shows the text too close to the bottom border:
Not sure if this will happen for other languages, though.
The text was updated successfully, but these errors were encountered: