Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛(dimail) fix imported mailboxes should be enabled instead of pending #659

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

mjeammet
Copy link
Contributor

@mjeammet mjeammet commented Jan 22, 2025

Purpose

Importing mailboxes creates pending mailboxes ... but these mailboxes are already active and, for most, functional. We thus mark them as "enabled".

Proposal

Description...

  • fixed related test
  • set imported mailboxes' statuses to "enabled"
  • for future PR : dimail provides a "status" field that can be either "ok" or "broken". our mailboxes could depend on this status but it's currently not entirely reliable (many "broken" mailboxes actually are functioning).

Copy link
Contributor

@sdemagny sdemagny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;)

@mjeammet mjeammet force-pushed the mpj/dimail/fix-imported-mailboxes-statuses branch from a031406 to d705cea Compare January 27, 2025 10:03
@mjeammet mjeammet enabled auto-merge (rebase) January 27, 2025 10:14
Importing mailboxes creates pending mailboxes ... but these mailboxes are
already active and, for most, functional. We thus mark them as "enabled".
@mjeammet mjeammet force-pushed the mpj/dimail/fix-imported-mailboxes-statuses branch from d705cea to 8d87e65 Compare January 27, 2025 10:14
@mjeammet mjeammet merged commit 227ecd0 into main Jan 27, 2025
19 checks passed
@mjeammet mjeammet deleted the mpj/dimail/fix-imported-mailboxes-statuses branch January 27, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants