Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example Codes not working #84

Open
andrewkhardy opened this issue Dec 21, 2023 · 3 comments
Open

Example Codes not working #84

andrewkhardy opened this issue Dec 21, 2023 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@andrewkhardy
Copy link

andrewkhardy commented Dec 21, 2023

The graphene_treetest for example, gives me the error

ERROR: LoadError: UndefVarError: GridTree not defined

@iintSjds
Copy link
Member

Hi, thanks for this message. Actually the TreeMeshes part is still premature and under development, thus it's not formally included in the package yet. Some of the examples, on the other hand, was outdated, including the one you mentioned. I will update/remove the examples to date when I got time.

@iintSjds iintSjds added bug Something isn't working enhancement New feature or request labels Dec 21, 2023
@iintSjds iintSjds self-assigned this Dec 21, 2023
@andrewkhardy
Copy link
Author

Perhaps this is related then. I was handed code that has for example

using GreenFunc
using BrillouinZoneMeshes

DIM = 2
latvec = [sqrt(3.0)/2 -sqrt(3.0)/2; 0.5 0.5] .* 4 * π / (3) # reciprocal vectors
nq = 12
bzmesh = BrillouinZoneMeshes.BaseMesh.UniformMesh{DIM,nq}(sum(-latvec[:, i] / (2.0 * nq) for i in 1:2), latvec)

which gives me the error

UndefVarError: UniformMesh not defined

Has the code undergone some major revisions? Is there are place for good working examples, or is it still under construction and not usable currently?

@iintSjds
Copy link
Member

The code was revised some time ago, and for the example you have, the "UniformMesh" was renamed as "UMesh", with the interface also a bit different than what was written.
Nevertheless, the code itself should be working, although the examples were outdated. If you want some working examples for now, those involved in tests(included in test/runtests.jl) should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants