Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NUP-2506: Add missing Cells4 state fields to serialization #1417

Merged
merged 2 commits into from
Apr 10, 2018
Merged

NUP-2506: Add missing Cells4 state fields to serialization #1417

merged 2 commits into from
Apr 10, 2018

Conversation

lscheinkman
Copy link
Contributor

@rhyolight Please review.
This PR is required to fix other nupic serialization issues

rhyolight
rhyolight approved these changes Apr 10, 2018
View reviewed changes
Copy link
Member

@rhyolight rhyolight left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. The new tests looks right. Lots of missing things. I can't verify every line of C++ (especially related to syntax), but if that test passes and no other tests fail, LGTM.

@lscheinkman lscheinkman force-pushed the NUP-2506 branch 26 times, most recently from 039d463 to ae90537 Compare April 10, 2018 17:51
@lscheinkman lscheinkman mentioned this pull request Apr 10, 2018
Merged
@lscheinkman lscheinkman merged commit 4ad8b02 into numenta:master Apr 10, 2018
@lscheinkman lscheinkman deleted the NUP-2506 branch April 11, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhyolight rhyolight rhyolight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lscheinkman @rhyolight