-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SP not giving same output for same input with learning disabled #1380
Comments
…th no learning and 0 boosting
@scottpurdy I was not able to reproduce the issue. Can you review the tests I added to make sure it covers the issue?
|
@lscheinkman can you please open a PR with the tests? Actually I also wanted to get a reproducible example first. And I am also observing a "strange" behavior with c++ SP, which I'd acknowledge to this issue. |
@scottpurdy can you please give us details on how to reproduce the issue? Also, have you observed the issue when working with c++ class, or a python wrapper? |
Experienced with Python wrapper and @lscheinkman has a fix (related to dtype casting) |
Issue #1380: Validate python parameters passed to SP compute method
…th no learning and 0 boosting
numenta/nupic.core-legacy#1380: Fix SP tests with correct dtype values
With learning disabled and boosting set to
0
, the Python SP will give the exact same output when repeatedly given the same input.When the C++ SP is swapped in, the results vary dramatically. This should not be the case. If there is a dtype conversion issue, then we need to check for it and throw an exception.
The text was updated successfully, but these errors were encountered: