Added holidays parameter to date encoder #3822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/nupic/encoders/__init__.py src/nupic/encoders/multi.py tests/unit/nupic/encoders/pass_through_encoder_test.py tests/unit/nupic/encoders/sparse_pass_through_encoder_test.py
Added WARNING message when permutations runner job fails Added nupic-site.xml to .gitignore
Added holidays parameter to date encoder and added extra unit test Fixed a typo in unit tests and comments in date.py
|
@JonnoFTW Please investigate test failures in CI. |
|
@JonnoFTW Could separate the holiday feature from the other changes related to swarming? |
|
@lscheinkman my bad, I forgot to merge with upstream. It should be good now. Do you know how I can get it to stop listing those really old commits in every pull request? |
|
@JonnoFTW You can try using git rebase --interactive and squash the old commits |
|
I can squash and merge from the UI. |
|
Nice @JonnoFTW thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3821
Also fixed up some typos.