updated __init__.py to include missing encoders

[JonnoFTW]

Fixes #3480

Also fixed absolute package path for the PassThroughEncoder

[rhyolight]

Please update the import statements in

• unit/nupic/encoders/random_distributed_scalar_test.py
• unit/nupic/encoders/pass_through_encoder_test.py
• unit/nupic/encoders/sparse_pass_through_encoder_test.py
• nupic/encoders/multi.py

[JonnoFTW]

@rhyolight What did you want changed in multi.py? Do you want all the imports to use the format:

from nupic.encoders import ScalarEncoder

[rhyolight]

Yes, just for consistency's sake

…

Sent from my MegaPhone

On Mar 11, 2017, at 11:19 PM, Jonathan Mackenzie ***@***.***> wrote: @rhyolight What did you want changed in multi.py? Do you want all the imports to use the format: from nupic.encoders import ScalarEncoder — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[rhyolight]

Interesting test failure (some in all CI platforms)... 🤔

==================================== ERRORS ====================================
_______ ERROR collecting tests/unit/nupic/algorithms/sp_overlap_test.py ________
tests/unit/nupic/algorithms/sp_overlap_test.py:41: in <module>
    from nupic.encoders import scalar
venv/lib/python2.7/site-packages/nupic/encoders/__init__.py:36: in <module>
    from multi import MultiEncoder
venv/lib/python2.7/site-packages/nupic/encoders/multi.py:36: in <module>
    from nupic.encoders import bitsToString
E   ImportError: cannot import name bitsToString

[JonnoFTW]

@rhyolight I fixed the error, but now I get capnp errors:

____________________________________________________________________________________ ERROR collecting tests/unit/nupic/encoders/multi_test.py ____________________________________________________________________________________
tests/unit/nupic/encoders/multi_test.py:37: in <module>
    from nupic.encoders.multi_capnp import MultiEncoderProto
capnp/lib/capnp.pyx:3876: in capnp.lib.capnp._Loader.load_module (capnp/lib/capnp.cpp:78463)
    ???
capnp/lib/capnp.pyx:3855: in capnp.lib.capnp.load (capnp/lib/capnp.cpp:77938)
    ???
capnp/lib/capnp.pyx:3192: in capnp.lib.capnp.SchemaParser.load (capnp/lib/capnp.cpp:68839)
    ???
E   KjException: /home/CSEM/mack0242/.pyenv/versions/2.7.12/lib/python2.7/site-packages/nupic-0.5.8.dev0-py2.7.egg/nupic/encoders/adaptivescalar.capnp:0: failed: Duplicate ID @0xf11485b8c813b489.
E   stack: 0x7f79e78dbf68 0x7f79e82dc3e9 0x7f79e82dbf2a 0x7f79e82d2a1a 0x7f79e82d2f52 0x7f79e82d7346 0x7f79e82d743b 0x7f79e82d74fc 0x7f79e82d7544 0x7f79e82b7ff9 0x7f79e82b7246 0x7f79e82bb4ac 0x7f79e82cf945 0x7f79e82d72ce 0x7f79e82d056e 0x7f79e82d0877

Are these errors acceptable?

[rhyolight]

Oh, I did not expect that. @vitaly-krugl can you explain this at all? Seems like import changes should not affect capnp.

[rhyolight]

@JonnoFTW Can you merge in master and see if the builds pass?

[JonnoFTW]

@rhyolight can you have a look at this now?

[rhyolight]

Sorry I didn't catch this earlier.

[rhyolight]

According to our style guide, please import all encoders enclosed in parentheses to allow multiple lines.

[rhyolight]

Thanks Jonathan!