Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More (relevant) objects define __str__ for comfortable printouts #1518

Open
breznak opened this issue Nov 13, 2014 · 7 comments
Open

More (relevant) objects define __str__ for comfortable printouts #1518

breznak opened this issue Nov 13, 2014 · 7 comments

Comments

@breznak
Copy link
Member

breznak commented Nov 13, 2014

some classes define dump(), debug(), or prettyprint() for debugging, displaying the state of the object to human, others have nothing.

Let's unify this to def __str__(self) which should be a human readable (distinguishable) repr. of the object. Good candidates are encoders, anomaly class implements it, SP/TP could too.

This is more like a long-stretched task, if you see a good place, implement it 😈

@rhyolight
Copy link
Member

👍 This could be a good newbie task for someone who wants to get experience in the codebase.

@abhinavrai44
Copy link
Contributor

abhinavrai44 commented Apr 16, 2017

@rhyolight I've made changes to one class. If this is the way to go, then I'll like to take up this issue

@breznak
Copy link
Member Author

breznak commented Apr 18, 2017

I think it loos good! 👍
Can you open a PR @abhinavrai44 ?

@abhinavrai44
Copy link
Contributor

Yeah sure. :-)

@idcrisis
Copy link

Way to go Abhinav. Maybe some day we'll see the HTM for stocks module in QuantConnect or Collective2.

@abhinavrai44
Copy link
Contributor

Sorry for being late with the PR. I have internal assessments going on at college as of now. Will submit the PR this weekend for sure.

@breznak
Copy link
Member Author

breznak commented May 3, 2017

Implemented for some encoders now. Reopening for remainder + other classes (SP, ...)

@breznak breznak reopened this May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants