Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove assert checks #169

Closed
ab93 opened this issue May 3, 2023 · 1 comment · Fixed by #350
Closed

Remove assert checks #169

ab93 opened this issue May 3, 2023 · 1 comment · Fixed by #350
Assignees
@Subhashini014
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest

Comments

@ab93
Copy link
Member

ab93 commented May 3, 2023 •
edited
Loading

Describe the bug
Some parts of the code has assertion checks. Need to replace them with normal exceptions.

The two places where this is currently seen is:

Message from the maintainers:

Impacted by this bug? Give it a 👍. We often sort issues this way to know what to prioritize.
@ab93 ab93 added the bug Something isn't working label May 3, 2023
@ab93 ab93 mentioned this issue May 3, 2023
Merged
@ab93 ab93 added hacktoberfest good first issue Good for newcomers labels Oct 17, 2023
@ab93 ab93 mentioned this issue Oct 17, 2023
Open
@Subhashini014
Copy link

could you please assign me this issue.

@ab93 ab93 linked a pull request Mar 2, 2024 that will close this issue
feat!: support static threshold score adjustment #350
Merged
@ab93 ab93 closed this as completed in #350 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Subhashini014 Subhashini014

Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: support static threshold score adjustment numaproj/numalogic
2 participants
@ab93 @Subhashini014