diff --git a/qodana.sarif.json b/qodana.sarif.json
index 8b408d7cd..2768618be 100644
--- a/qodana.sarif.json
+++ b/qodana.sarif.json
@@ -93514,27 +93514,27 @@
]
},
{
- "id": "JSCheckFunctionSignatures",
+ "id": "ConstantOnLHSOfComparisonJS",
"shortDescription": {
- "text": "Signature mismatch"
+ "text": "Constant on left side of comparison"
},
"fullDescription": {
- "text": "Reports a JavaScript call expression where the arguments do not match the signature of the referenced function, including the types of arguments and their number. Also, reports if the overloading function doesn't match the overloaded one in terms of parameters and return types. TypeScript code is ignored.",
- "markdown": "Reports a JavaScript call expression where the arguments do not match the signature of the referenced function, including the types of arguments and their number. Also, reports if the overloading function doesn't match the overloaded one in terms of parameters and return types.\n\nTypeScript code is ignored."
+ "text": "Reports a comparison operation with a constant value in the left-hand side. According to coding conventions, constants should be in the right-hand side of comparisons.",
+ "markdown": "Reports a comparison operation with a constant value in the left-hand side. According to coding conventions, constants should be in the right-hand side of comparisons."
},
"defaultConfiguration": {
- "enabled": true,
- "level": "note",
+ "enabled": false,
+ "level": "warning",
"parameters": {
- "ideaSeverity": "WEAK WARNING",
- "qodanaSeverity": "Moderate"
+ "ideaSeverity": "WARNING",
+ "qodanaSeverity": "High"
}
},
"relationships": [
{
"target": {
- "id": "JavaScript and TypeScript/General",
- "index": 16,
+ "id": "JavaScript and TypeScript/Code style issues",
+ "index": 69,
"toolComponent": {
"name": "QDNET"
}
@@ -93546,27 +93546,27 @@
]
},
{
- "id": "ConstantOnLHSOfComparisonJS",
+ "id": "JSCheckFunctionSignatures",
"shortDescription": {
- "text": "Constant on left side of comparison"
+ "text": "Signature mismatch"
},
"fullDescription": {
- "text": "Reports a comparison operation with a constant value in the left-hand side. According to coding conventions, constants should be in the right-hand side of comparisons.",
- "markdown": "Reports a comparison operation with a constant value in the left-hand side. According to coding conventions, constants should be in the right-hand side of comparisons."
+ "text": "Reports a JavaScript call expression where the arguments do not match the signature of the referenced function, including the types of arguments and their number. Also, reports if the overloading function doesn't match the overloaded one in terms of parameters and return types. TypeScript code is ignored.",
+ "markdown": "Reports a JavaScript call expression where the arguments do not match the signature of the referenced function, including the types of arguments and their number. Also, reports if the overloading function doesn't match the overloaded one in terms of parameters and return types.\n\nTypeScript code is ignored."
},
"defaultConfiguration": {
- "enabled": false,
- "level": "warning",
+ "enabled": true,
+ "level": "note",
"parameters": {
- "ideaSeverity": "WARNING",
- "qodanaSeverity": "High"
+ "ideaSeverity": "WEAK WARNING",
+ "qodanaSeverity": "Moderate"
}
},
"relationships": [
{
"target": {
- "id": "JavaScript and TypeScript/Code style issues",
- "index": 69,
+ "id": "JavaScript and TypeScript/General",
+ "index": 16,
"toolComponent": {
"name": "QDNET"
}
@@ -94506,16 +94506,16 @@
]
},
{
- "id": "ES6UnusedImports",
+ "id": "InnerHTMLJS",
"shortDescription": {
- "text": "Unused import"
+ "text": "Use of 'innerHTML' property"
},
"fullDescription": {
- "text": "Reports a redundant 'import' statement. This is usually the case if the imported symbols are not used in the source file. To avoid side-effects, consider using bare import 'import 'packageName'' instead of the regular one.",
- "markdown": "Reports a redundant `import` statement. This is usually the case if the imported symbols are not used in the source file. To avoid side-effects, consider using bare import `import 'packageName'` instead of the regular one."
+ "text": "Reports a JavaScript access to DOM nodes as text using the 'innerHTML' property. Most usages of 'innerHTML' are performed better with explicit DOM calls, such as 'getElementByID()' and 'createElement()'. Additionally, 'innerHTML' will not work with XML DOMs, including DOMs for XHTML if viewed as XML. This can lead to difficulties in diagnosing bugs.",
+ "markdown": "Reports a JavaScript access to DOM nodes as text using the `innerHTML` property. Most usages of `innerHTML` are performed better with explicit DOM calls, such as `getElementByID()` and `createElement()`. Additionally, `innerHTML` will not work with XML DOMs, including DOMs for XHTML if viewed as XML. This can lead to difficulties in diagnosing bugs."
},
"defaultConfiguration": {
- "enabled": true,
+ "enabled": false,
"level": "warning",
"parameters": {
"ideaSeverity": "WARNING",
@@ -94525,8 +94525,8 @@
"relationships": [
{
"target": {
- "id": "JavaScript and TypeScript/Imports and dependencies",
- "index": 104,
+ "id": "JavaScript and TypeScript/DOM issues",
+ "index": 45,
"toolComponent": {
"name": "QDNET"
}
@@ -94538,16 +94538,16 @@
]
},
{
- "id": "InnerHTMLJS",
+ "id": "ES6UnusedImports",
"shortDescription": {
- "text": "Use of 'innerHTML' property"
+ "text": "Unused import"
},
"fullDescription": {
- "text": "Reports a JavaScript access to DOM nodes as text using the 'innerHTML' property. Most usages of 'innerHTML' are performed better with explicit DOM calls, such as 'getElementByID()' and 'createElement()'. Additionally, 'innerHTML' will not work with XML DOMs, including DOMs for XHTML if viewed as XML. This can lead to difficulties in diagnosing bugs.",
- "markdown": "Reports a JavaScript access to DOM nodes as text using the `innerHTML` property. Most usages of `innerHTML` are performed better with explicit DOM calls, such as `getElementByID()` and `createElement()`. Additionally, `innerHTML` will not work with XML DOMs, including DOMs for XHTML if viewed as XML. This can lead to difficulties in diagnosing bugs."
+ "text": "Reports a redundant 'import' statement. This is usually the case if the imported symbols are not used in the source file. To avoid side-effects, consider using bare import 'import 'packageName'' instead of the regular one.",
+ "markdown": "Reports a redundant `import` statement. This is usually the case if the imported symbols are not used in the source file. To avoid side-effects, consider using bare import `import 'packageName'` instead of the regular one."
},
"defaultConfiguration": {
- "enabled": false,
+ "enabled": true,
"level": "warning",
"parameters": {
"ideaSeverity": "WARNING",
@@ -94557,8 +94557,8 @@
"relationships": [
{
"target": {
- "id": "JavaScript and TypeScript/DOM issues",
- "index": 45,
+ "id": "JavaScript and TypeScript/Imports and dependencies",
+ "index": 104,
"toolComponent": {
"name": "QDNET"
}
@@ -101454,27 +101454,27 @@
]
},
{
- "id": "SqlCallNotationInspection",
+ "id": "MysqlParsingInspection",
"shortDescription": {
- "text": "Using of named and positional arguments"
+ "text": "Unsupported syntax in pre-8.0 versions"
},
"fullDescription": {
- "text": "Reports calls in which positional arguments go after the named ones. Works in PostgreSQL, Oracle, and Db2. Example (In PostgreSQL): 'CREATE FUNCTION foo(a int, b int, c int) RETURNS int\n LANGUAGE plpgsql AS\n$$\nBEGIN\n RETURN a + b + c;\nEND\n$$;\nSELECT foo(a => 1, b => 2, c => 3);\n -- `3` goes after the named argument\nSELECT foo(1, b => 2, 3);\n -- `1` and `3` go after the named argument\nSELECT foo(b => 2, 1, 3);'",
- "markdown": "Reports calls in which positional arguments go after the named ones. Works in PostgreSQL, Oracle, and Db2.\n\nExample (In PostgreSQL):\n\n CREATE FUNCTION foo(a int, b int, c int) RETURNS int\n LANGUAGE plpgsql AS\n $$\n BEGIN\n RETURN a + b + c;\n END\n $$;\n SELECT foo(a => 1, b => 2, c => 3);\n -- `3` goes after the named argument\n SELECT foo(1, b => 2, 3);\n -- `1` and `3` go after the named argument\n SELECT foo(b => 2, 1, 3);\n"
+ "text": "Reports invalid usages of UNION in queries. The inspection works in MySQL versions that are earlier than 8.0. Example (MySQL): 'SELECT * FROM (SELECT 1 UNION (SELECT 1 UNION SELECT 2)) a;'",
+ "markdown": "Reports invalid usages of UNION in queries.\n\nThe inspection works in MySQL versions that are earlier than 8.0.\n\nExample (MySQL):\n\n\n SELECT * FROM (SELECT 1 UNION (SELECT 1 UNION SELECT 2)) a;\n"
},
"defaultConfiguration": {
"enabled": false,
- "level": "error",
+ "level": "warning",
"parameters": {
- "ideaSeverity": "ERROR",
- "qodanaSeverity": "Critical"
+ "ideaSeverity": "WARNING",
+ "qodanaSeverity": "High"
}
},
"relationships": [
{
"target": {
- "id": "SQL",
- "index": 23,
+ "id": "MySQL",
+ "index": 115,
"toolComponent": {
"name": "QDNET"
}
@@ -101486,27 +101486,27 @@
]
},
{
- "id": "MysqlParsingInspection",
+ "id": "SqlCallNotationInspection",
"shortDescription": {
- "text": "Unsupported syntax in pre-8.0 versions"
+ "text": "Using of named and positional arguments"
},
"fullDescription": {
- "text": "Reports invalid usages of UNION in queries. The inspection works in MySQL versions that are earlier than 8.0. Example (MySQL): 'SELECT * FROM (SELECT 1 UNION (SELECT 1 UNION SELECT 2)) a;'",
- "markdown": "Reports invalid usages of UNION in queries.\n\nThe inspection works in MySQL versions that are earlier than 8.0.\n\nExample (MySQL):\n\n\n SELECT * FROM (SELECT 1 UNION (SELECT 1 UNION SELECT 2)) a;\n"
+ "text": "Reports calls in which positional arguments go after the named ones. Works in PostgreSQL, Oracle, and Db2. Example (In PostgreSQL): 'CREATE FUNCTION foo(a int, b int, c int) RETURNS int\n LANGUAGE plpgsql AS\n$$\nBEGIN\n RETURN a + b + c;\nEND\n$$;\nSELECT foo(a => 1, b => 2, c => 3);\n -- `3` goes after the named argument\nSELECT foo(1, b => 2, 3);\n -- `1` and `3` go after the named argument\nSELECT foo(b => 2, 1, 3);'",
+ "markdown": "Reports calls in which positional arguments go after the named ones. Works in PostgreSQL, Oracle, and Db2.\n\nExample (In PostgreSQL):\n\n CREATE FUNCTION foo(a int, b int, c int) RETURNS int\n LANGUAGE plpgsql AS\n $$\n BEGIN\n RETURN a + b + c;\n END\n $$;\n SELECT foo(a => 1, b => 2, c => 3);\n -- `3` goes after the named argument\n SELECT foo(1, b => 2, 3);\n -- `1` and `3` go after the named argument\n SELECT foo(b => 2, 1, 3);\n"
},
"defaultConfiguration": {
"enabled": false,
- "level": "warning",
+ "level": "error",
"parameters": {
- "ideaSeverity": "WARNING",
- "qodanaSeverity": "High"
+ "ideaSeverity": "ERROR",
+ "qodanaSeverity": "Critical"
}
},
"relationships": [
{
"target": {
- "id": "MySQL",
- "index": 115,
+ "id": "SQL",
+ "index": 23,
"toolComponent": {
"name": "QDNET"
}
@@ -104611,7 +104611,7 @@
"markdown": "Reports the Qodana service messages such as suspending a particular inspection due to a large number of reported problems."
},
"defaultConfiguration": {
- "enabled": false,
+ "enabled": true,
"level": "error",
"parameters": {
"ideaSeverity": "ERROR",
@@ -104742,11 +104742,11 @@
"language": "en-US",
"versionControlProvenance": [
{
- "repositoryUri": "https://github.com/nuke-build/nuke.git",
- "revisionId": "9e59736edf7e167bd6f98abf87709688ee695fd1",
+ "repositoryUri": "ssh://git@github.com/nuke-build/nuke",
+ "revisionId": "1f58195dbff00a53a8873eb822a3daeeb1da25dc",
"branch": "develop",
"properties": {
- "repoUrl": "https://github.com/nuke-build/nuke.git",
+ "repoUrl": "",
"lastAuthorName": "Matthias Koch",
"vcsType": "Git",
"lastAuthorEmail": "ithrowexceptions@gmail.com"
@@ -104754,62 +104754,6 @@
}
],
"results": [
- {
- "ruleId": "UseAwaitUsing",
- "kind": "fail",
- "level": "note",
- "message": {
- "text": "Use 'await using'",
- "markdown": "Use 'await using'"
- },
- "locations": [
- {
- "physicalLocation": {
- "artifactLocation": {
- "uri": "source/Nuke.Common/Tools/SignPath/SignPathTasks.cs",
- "uriBaseId": "SRCROOT"
- },
- "region": {
- "startLine": 138,
- "startColumn": 13,
- "charOffset": 5959,
- "charLength": 5,
- "snippet": {
- "text": "using"
- },
- "sourceLanguage": "C#"
- },
- "contextRegion": {
- "startLine": 136,
- "startColumn": 1,
- "charOffset": 5897,
- "charLength": 270,
- "snippet": {
- "text": "\n outputPath.Parent.CreateDirectory();\n using var fileStream = File.Open(outputPath, FileMode.Create);\n await downloadStream.CopyToAsync(fileStream);\n Log.Information(\"Signed artifact downloaded to: {OutputPath}\", outputPath);"
- }
- }
- },
- "logicalLocations": [
- {
- "fullyQualifiedName": "Nuke.Common",
- "kind": "module"
- }
- ]
- }
- ],
- "partialFingerprints": {
- "equalIndicator/v1": "731e10f59f9a6d6f67b087d9eeff71881c1752a834069f524a0d0ba767e162c4"
- },
- "baselineState": "unchanged",
- "properties": {
- "ideaSeverity": "WEAK WARNING",
- "qodanaSeverity": "Moderate",
- "tags": [
- "C#",
- ".NET 6.0"
- ]
- }
- },
{
"ruleId": "UseAwaitUsing",
"kind": "fail",
@@ -104856,7 +104800,6 @@
"partialFingerprints": {
"equalIndicator/v1": "299d39ef40d01215291cb09130c64f53dc1b847b1ba56fa658df5b90f5e88aad"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -104867,52 +104810,51 @@
}
},
{
- "ruleId": "RedundantArrayCreationExpression",
+ "ruleId": "UseAwaitUsing",
"kind": "fail",
"level": "note",
"message": {
- "text": "Redundant array creation expression",
- "markdown": "Redundant array creation expression"
+ "text": "Use 'await using'",
+ "markdown": "Use 'await using'"
},
"locations": [
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Common.Tests/CI/ConfigurationGenerationTest.cs",
+ "uri": "source/Nuke.Common/Tools/SignPath/SignPathTasks.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 201,
- "startColumn": 60,
- "charOffset": 8260,
+ "startLine": 138,
+ "startColumn": 13,
+ "charOffset": 5959,
"charLength": 5,
"snippet": {
- "text": "new[]"
+ "text": "using"
},
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 199,
+ "startLine": 136,
"startColumn": 1,
- "charOffset": 8125,
- "charLength": 363,
+ "charOffset": 5897,
+ "charLength": 270,
"snippet": {
- "text": " public readonly Configuration Configuration = Configuration.Debug;\n\n [Parameter] public readonly string[] StringArray = new[] { \"first\", \"second\" };\n [Parameter] public readonly int[] IntegerArray = new[] { 1, 2 };\n [Parameter] public readonly Configuration[] ConfigurationArray = new[] { Configuration.Debug, Configuration.Release };"
+ "text": "\n outputPath.Parent.CreateDirectory();\n using var fileStream = File.Open(outputPath, FileMode.Create);\n await downloadStream.CopyToAsync(fileStream);\n Log.Information(\"Signed artifact downloaded to: {OutputPath}\", outputPath);"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Common.Tests",
+ "fullyQualifiedName": "Nuke.Common",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "2ccc2f5654c6c3d17caa97b712825994ca3849ac71df4a25d7819f50c36169a3"
+ "equalIndicator/v1": "731e10f59f9a6d6f67b087d9eeff71881c1752a834069f524a0d0ba767e162c4"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -104923,52 +104865,51 @@
}
},
{
- "ruleId": "RedundantArrayCreationExpression",
+ "ruleId": "ConvertIfStatementToSwitchStatement",
"kind": "fail",
"level": "note",
"message": {
- "text": "Redundant array creation expression",
- "markdown": "Redundant array creation expression"
+ "text": "Convert 'if' statement into 'switch' statement",
+ "markdown": "Convert 'if' statement into 'switch' statement"
},
"locations": [
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Common.Tests/CI/ConfigurationGenerationTest.cs",
+ "uri": "source/Nuke.Common/Tools/DotNet/DotNetTasks.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 202,
- "startColumn": 58,
- "charOffset": 8346,
- "charLength": 5,
+ "startLine": 54,
+ "startColumn": 13,
+ "charOffset": 1288,
+ "charLength": 2,
"snippet": {
- "text": "new[]"
+ "text": "if"
},
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 200,
+ "startLine": 52,
"startColumn": 1,
- "charOffset": 8200,
- "charLength": 289,
+ "charOffset": 1261,
+ "charLength": 120,
"snippet": {
- "text": "\n [Parameter] public readonly string[] StringArray = new[] { \"first\", \"second\" };\n [Parameter] public readonly int[] IntegerArray = new[] { 1, 2 };\n [Parameter] public readonly Configuration[] ConfigurationArray = new[] { Configuration.Debug, Configuration.Release };\n"
+ "text": " }\n\n if (i >= 4 &&\n 'e' == output[i - 4] &&\n 'r' == output[i - 3] &&"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Common.Tests",
+ "fullyQualifiedName": "Nuke.Common",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "d26b8da2179894da4d4368625599802e8d0aa4c8a52fdbe75525f2a7a09fec36"
+ "equalIndicator/v1": "4e064482f4fad823772f7e2a37e71a552613e447968c62bf80e8bde1014b391e"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -104979,52 +104920,51 @@
}
},
{
- "ruleId": "RedundantArrayCreationExpression",
+ "ruleId": "ConvertIfStatementToSwitchStatement",
"kind": "fail",
"level": "note",
"message": {
- "text": "Redundant array creation expression",
- "markdown": "Redundant array creation expression"
+ "text": "Convert 'if' statement into 'switch' statement",
+ "markdown": "Convert 'if' statement into 'switch' statement"
},
"locations": [
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Common.Tests/CI/ConfigurationGenerationTest.cs",
+ "uri": "source/Nuke.Build/Utilities/ConsoleUtility.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 203,
- "startColumn": 74,
- "charOffset": 8435,
- "charLength": 5,
+ "startLine": 60,
+ "startColumn": 18,
+ "charOffset": 1954,
+ "charLength": 2,
"snippet": {
- "text": "new[]"
+ "text": "if"
},
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 201,
+ "startLine": 58,
"startColumn": 1,
- "charOffset": 8201,
- "charLength": 361,
+ "charOffset": 1812,
+ "charLength": 303,
"snippet": {
- "text": " [Parameter] public readonly string[] StringArray = new[] { \"first\", \"second\" };\n [Parameter] public readonly int[] IntegerArray = new[] { 1, 2 };\n [Parameter] public readonly Configuration[] ConfigurationArray = new[] { Configuration.Debug, Configuration.Release };\n\n public AbsolutePath OutputDirectory => RootDirectory / \"output\";"
+ "text": " || new[] { '.', '/', '\\\\', '_', '-' }.Any(x => x == key.KeyChar))\n input.Append(key.KeyChar);\n else if (key.Key == ConsoleKey.Backspace && input.Length > 0)\n input.Remove(input.Length - 1, length: 1);\n else if (key.Key == InterruptKey)"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Common.Tests",
+ "fullyQualifiedName": "Nuke.Build",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "fe04c75607792591a0a1681cceae44ad9ce4bad215840e8a2889e504efdfc166"
+ "equalIndicator/v1": "a32a29aa50e3c87864e89e0bdc1f48e42f60157197e122a7b7ee288c02d32dc1"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -105046,13 +104986,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Common/Tools/DotNet/DotNetTasks.cs",
+ "uri": "source/Nuke.Build/Utilities/ConsoleUtility.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 54,
+ "startLine": 94,
"startColumn": 13,
- "charOffset": 1288,
+ "charOffset": 3257,
"charLength": 2,
"snippet": {
"text": "if"
@@ -105060,27 +105000,26 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 52,
+ "startLine": 92,
"startColumn": 1,
- "charOffset": 1261,
- "charLength": 120,
+ "charOffset": 3188,
+ "charLength": 178,
"snippet": {
- "text": " }\n\n if (i >= 4 &&\n 'e' == output[i - 4] &&\n 'r' == output[i - 3] &&"
+ "text": "\n key = Console.ReadKey(intercept: true).Key;\n if (key == ConsoleKey.UpArrow)\n selection--;\n else if (key == ConsoleKey.DownArrow)"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Common",
+ "fullyQualifiedName": "Nuke.Build",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "4e064482f4fad823772f7e2a37e71a552613e447968c62bf80e8bde1014b391e"
+ "equalIndicator/v1": "31306390c6008678271f03da7f8bf0c7d363b7ede0feb2ab02da65e062dd1acc"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -105102,13 +105041,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Build/Utilities/ConsoleUtility.cs",
+ "uri": "source/Nuke.Build/Host.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 60,
- "startColumn": 18,
- "charOffset": 1954,
+ "startLine": 183,
+ "startColumn": 13,
+ "charOffset": 6456,
"charLength": 2,
"snippet": {
"text": "if"
@@ -105116,12 +105055,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 58,
+ "startLine": 181,
"startColumn": 1,
- "charOffset": 1812,
- "charLength": 303,
+ "charOffset": 6390,
+ "charLength": 233,
"snippet": {
- "text": " || new[] { '.', '/', '\\\\', '_', '-' }.Any(x => x == key.KeyChar))\n input.Append(key.KeyChar);\n else if (key.Key == ConsoleKey.Backspace && input.Length > 0)\n input.Remove(input.Length - 1, length: 1);\n else if (key.Key == InterruptKey)"
+ "text": " public void Emit(LogEvent logEvent)\n {\n if (logEvent.Level == LogEventLevel.Warning)\n _host.ReportWarning(logEvent.RenderMessage());\n else if (logEvent.Level == LogEventLevel.Error)"
}
}
},
@@ -105134,9 +105073,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "a32a29aa50e3c87864e89e0bdc1f48e42f60157197e122a7b7ee288c02d32dc1"
+ "equalIndicator/v1": "6ba6c39e1ce8cabd22f9998ad4f0ea8e80e8c4cd23a895dc5f6dbdc1fdd1f3de"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -105151,20 +105089,20 @@
"kind": "fail",
"level": "note",
"message": {
- "text": "Convert 'if' statement into 'switch' statement",
- "markdown": "Convert 'if' statement into 'switch' statement"
+ "text": "Convert 'if' statement into 'switch'",
+ "markdown": "Convert 'if' statement into 'switch'"
},
"locations": [
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Build/Utilities/ConsoleUtility.cs",
+ "uri": "source/Nuke.Utilities/IO/AbsolutePath.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 94,
+ "startLine": 42,
"startColumn": 13,
- "charOffset": 3257,
+ "charOffset": 1347,
"charLength": 2,
"snippet": {
"text": "if"
@@ -105172,27 +105110,26 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 92,
+ "startLine": 40,
"startColumn": 1,
- "charOffset": 3188,
- "charLength": 178,
+ "charOffset": 1215,
+ "charLength": 226,
"snippet": {
- "text": "\n key = Console.ReadKey(intercept: true).Key;\n if (key == ConsoleKey.UpArrow)\n selection--;\n else if (key == ConsoleKey.DownArrow)"
+ "text": " public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object value)\n {\n if (value is string stringValue)\n {\n return HasPathRoot(stringValue)"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Build",
+ "fullyQualifiedName": "Nuke.Utilities",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "31306390c6008678271f03da7f8bf0c7d363b7ede0feb2ab02da65e062dd1acc"
+ "equalIndicator/v1": "5afcda287550fc8aa6efc6bbda0d739f887fb3f0762c1d90dd3516959bbadb13"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -105202,6 +105139,61 @@
]
}
},
+ {
+ "ruleId": "ConvertIfStatementToSwitchStatement",
+ "kind": "fail",
+ "level": "note",
+ "message": {
+ "text": "Convert 'if' statement into 'switch'",
+ "markdown": "Convert 'if' statement into 'switch'"
+ },
+ "locations": [
+ {
+ "physicalLocation": {
+ "artifactLocation": {
+ "uri": "source/Nuke.Utilities/IO/AbsolutePath.cs",
+ "uriBaseId": "SRCROOT"
+ },
+ "region": {
+ "startLine": 42,
+ "startColumn": 13,
+ "charOffset": 1347,
+ "charLength": 2,
+ "snippet": {
+ "text": "if"
+ },
+ "sourceLanguage": "C#"
+ },
+ "contextRegion": {
+ "startLine": 40,
+ "startColumn": 1,
+ "charOffset": 1215,
+ "charLength": 226,
+ "snippet": {
+ "text": " public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object value)\n {\n if (value is string stringValue)\n {\n return HasPathRoot(stringValue)"
+ }
+ }
+ },
+ "logicalLocations": [
+ {
+ "fullyQualifiedName": "Nuke.Utilities",
+ "kind": "module"
+ }
+ ]
+ }
+ ],
+ "partialFingerprints": {
+ "equalIndicator/v1": "7bd0926acee5470b4262f22c186ca6363d475f030554e8865dd9dcfaa36cf213"
+ },
+ "properties": {
+ "ideaSeverity": "WEAK WARNING",
+ "qodanaSeverity": "Moderate",
+ "tags": [
+ "C#",
+ ".NETStandard 2.0"
+ ]
+ }
+ },
{
"ruleId": "ConvertIfStatementToSwitchStatement",
"kind": "fail",
@@ -105246,15 +105238,14 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "3e15234a19dabe01e5a88ec2d56ceaaa5f23051d7af584be23cb63ff7a2d285a"
+ "equalIndicator/v1": "4f9a51eb5664d8008603e7390ca59afa959f4c59eff8fcbd1f9bd9dd74befc03"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
"tags": [
"C#",
- ".NETStandard 2.0"
+ ".NET 6.0"
]
}
},
@@ -105302,15 +105293,14 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "4f9a51eb5664d8008603e7390ca59afa959f4c59eff8fcbd1f9bd9dd74befc03"
+ "equalIndicator/v1": "3e15234a19dabe01e5a88ec2d56ceaaa5f23051d7af584be23cb63ff7a2d285a"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
"tags": [
"C#",
- ".NET 6.0"
+ ".NETStandard 2.0"
]
}
},
@@ -105326,13 +105316,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Build/Host.cs",
+ "uri": "source/Nuke.Utilities/ArgumentParser.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 183,
- "startColumn": 13,
- "charOffset": 6456,
+ "startLine": 38,
+ "startColumn": 21,
+ "charOffset": 991,
"charLength": 2,
"snippet": {
"text": "if"
@@ -105340,27 +105330,26 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 181,
+ "startLine": 36,
"startColumn": 1,
- "charOffset": 6390,
- "charLength": 233,
+ "charOffset": 912,
+ "charLength": 183,
"snippet": {
- "text": " public void Emit(LogEvent logEvent)\n {\n if (logEvent.Level == LogEventLevel.Warning)\n _host.ReportWarning(logEvent.RenderMessage());\n else if (logEvent.Level == LogEventLevel.Error)"
+ "text": " return arguments.Split((c, _) =>\n {\n if (c == '\\\"' && !inSingleQuotes && !escaped)\n inDoubleQuotes = !inDoubleQuotes;\n"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Build",
+ "fullyQualifiedName": "Nuke.Utilities",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "6ba6c39e1ce8cabd22f9998ad4f0ea8e80e8c4cd23a895dc5f6dbdc1fdd1f3de"
+ "equalIndicator/v1": "3bea2b817c4ee57d1b91038ac00a2abfabd411879f811ff925babda01657088d"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -105382,13 +105371,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.GlobalTool/Program.Secrets.cs",
+ "uri": "source/Nuke.Utilities/ArgumentParser.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 75,
- "startColumn": 17,
- "charOffset": 3010,
+ "startLine": 38,
+ "startColumn": 21,
+ "charOffset": 991,
"charLength": 2,
"snippet": {
"text": "if"
@@ -105396,33 +105385,32 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 73,
+ "startLine": 36,
"startColumn": 1,
- "charOffset": 2963,
- "charLength": 147,
+ "charOffset": 912,
+ "charLength": 183,
"snippet": {
- "text": " else\n {\n if (choice == SaveAndExit)\n SaveSecrets(addedSecrets, password, parametersFile);\n"
+ "text": " return arguments.Split((c, _) =>\n {\n if (c == '\\\"' && !inSingleQuotes && !escaped)\n inDoubleQuotes = !inDoubleQuotes;\n"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.GlobalTool",
+ "fullyQualifiedName": "Nuke.Utilities",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "3a0d226d122a01f05512dd9ee3259e4de389cfb58f07ef2e1a34e58f73a4f048"
+ "equalIndicator/v1": "1ade858c08db16a16e6985a3554ec92839760d119e8973c6e71178ad45e5843a"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
"tags": [
"C#",
- ".NET 6.0"
+ ".NETStandard 2.0"
]
}
},
@@ -105472,7 +105460,6 @@
"partialFingerprints": {
"equalIndicator/v1": "6687cf8e883711e2ac772fde80ceee9ab134641d1c60f9984c2c1816003b2c5a"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -105528,7 +105515,6 @@
"partialFingerprints": {
"equalIndicator/v1": "e86e6871c4934613166ed58ed597643f7f19907cc0f07f7982eff495be945784"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -105543,20 +105529,20 @@
"kind": "fail",
"level": "note",
"message": {
- "text": "Convert 'if' statement into 'switch' statement",
- "markdown": "Convert 'if' statement into 'switch' statement"
+ "text": "Convert 'if' statement into 'switch'",
+ "markdown": "Convert 'if' statement into 'switch'"
},
"locations": [
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/ArgumentParser.cs",
+ "uri": "source/Nuke.GlobalTool/Rewriting/Cake/CodeAnalysisExtensions.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 38,
- "startColumn": 21,
- "charOffset": 991,
+ "startLine": 102,
+ "startColumn": 9,
+ "charOffset": 3752,
"charLength": 2,
"snippet": {
"text": "if"
@@ -105564,33 +105550,32 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 36,
+ "startLine": 100,
"startColumn": 1,
- "charOffset": 912,
- "charLength": 183,
+ "charOffset": 3657,
+ "charLength": 216,
"snippet": {
- "text": " return arguments.Split((c, _) =>\n {\n if (c == '\\\"' && !inSingleQuotes && !escaped)\n inDoubleQuotes = !inDoubleQuotes;\n"
+ "text": " public static TypeSyntax GetExpressionType(this ExpressionSyntax expression)\n {\n if (expression is LiteralExpressionSyntax literalExpression)\n {\n return literalExpression.Kind() switch"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Utilities",
+ "fullyQualifiedName": "Nuke.GlobalTool",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "1ade858c08db16a16e6985a3554ec92839760d119e8973c6e71178ad45e5843a"
+ "equalIndicator/v1": "992ba780ad338cc23e05fdd23c55d9e5cd7293e74c508c958b55163d37a4ffdd"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
"tags": [
"C#",
- ".NETStandard 2.0"
+ ".NET 6.0"
]
}
},
@@ -105606,13 +105591,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/ArgumentParser.cs",
+ "uri": "source/Nuke.GlobalTool/Program.Secrets.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 38,
- "startColumn": 21,
- "charOffset": 991,
+ "startLine": 75,
+ "startColumn": 17,
+ "charOffset": 3010,
"charLength": 2,
"snippet": {
"text": "if"
@@ -105620,27 +105605,26 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 36,
+ "startLine": 73,
"startColumn": 1,
- "charOffset": 912,
- "charLength": 183,
+ "charOffset": 2963,
+ "charLength": 147,
"snippet": {
- "text": " return arguments.Split((c, _) =>\n {\n if (c == '\\\"' && !inSingleQuotes && !escaped)\n inDoubleQuotes = !inDoubleQuotes;\n"
+ "text": " else\n {\n if (choice == SaveAndExit)\n SaveSecrets(addedSecrets, password, parametersFile);\n"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Utilities",
+ "fullyQualifiedName": "Nuke.GlobalTool",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "3bea2b817c4ee57d1b91038ac00a2abfabd411879f811ff925babda01657088d"
+ "equalIndicator/v1": "3a0d226d122a01f05512dd9ee3259e4de389cfb58f07ef2e1a34e58f73a4f048"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -105651,52 +105635,51 @@
}
},
{
- "ruleId": "ConvertIfStatementToSwitchStatement",
+ "ruleId": "RedundantArrayCreationExpression",
"kind": "fail",
"level": "note",
"message": {
- "text": "Convert 'if' statement into 'switch'",
- "markdown": "Convert 'if' statement into 'switch'"
+ "text": "Redundant array creation expression",
+ "markdown": "Redundant array creation expression"
},
"locations": [
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.GlobalTool/Rewriting/Cake/CodeAnalysisExtensions.cs",
+ "uri": "source/Nuke.Common.Tests/CI/ConfigurationGenerationTest.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 102,
- "startColumn": 9,
- "charOffset": 3752,
- "charLength": 2,
+ "startLine": 201,
+ "startColumn": 60,
+ "charOffset": 8260,
+ "charLength": 5,
"snippet": {
- "text": "if"
+ "text": "new[]"
},
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 100,
+ "startLine": 199,
"startColumn": 1,
- "charOffset": 3657,
- "charLength": 216,
+ "charOffset": 8125,
+ "charLength": 363,
"snippet": {
- "text": " public static TypeSyntax GetExpressionType(this ExpressionSyntax expression)\n {\n if (expression is LiteralExpressionSyntax literalExpression)\n {\n return literalExpression.Kind() switch"
+ "text": " public readonly Configuration Configuration = Configuration.Debug;\n\n [Parameter] public readonly string[] StringArray = new[] { \"first\", \"second\" };\n [Parameter] public readonly int[] IntegerArray = new[] { 1, 2 };\n [Parameter] public readonly Configuration[] ConfigurationArray = new[] { Configuration.Debug, Configuration.Release };"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.GlobalTool",
+ "fullyQualifiedName": "Nuke.Common.Tests",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "992ba780ad338cc23e05fdd23c55d9e5cd7293e74c508c958b55163d37a4ffdd"
+ "equalIndicator/v1": "2ccc2f5654c6c3d17caa97b712825994ca3849ac71df4a25d7819f50c36169a3"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -105707,108 +105690,106 @@
}
},
{
- "ruleId": "ConvertIfStatementToSwitchStatement",
+ "ruleId": "RedundantArrayCreationExpression",
"kind": "fail",
"level": "note",
"message": {
- "text": "Convert 'if' statement into 'switch'",
- "markdown": "Convert 'if' statement into 'switch'"
+ "text": "Redundant array creation expression",
+ "markdown": "Redundant array creation expression"
},
"locations": [
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/IO/AbsolutePath.cs",
+ "uri": "source/Nuke.Common.Tests/CI/ConfigurationGenerationTest.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 42,
- "startColumn": 13,
- "charOffset": 1347,
- "charLength": 2,
+ "startLine": 202,
+ "startColumn": 58,
+ "charOffset": 8346,
+ "charLength": 5,
"snippet": {
- "text": "if"
+ "text": "new[]"
},
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 40,
+ "startLine": 200,
"startColumn": 1,
- "charOffset": 1215,
- "charLength": 226,
+ "charOffset": 8200,
+ "charLength": 289,
"snippet": {
- "text": " public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object value)\n {\n if (value is string stringValue)\n {\n return HasPathRoot(stringValue)"
+ "text": "\n [Parameter] public readonly string[] StringArray = new[] { \"first\", \"second\" };\n [Parameter] public readonly int[] IntegerArray = new[] { 1, 2 };\n [Parameter] public readonly Configuration[] ConfigurationArray = new[] { Configuration.Debug, Configuration.Release };\n"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Utilities",
+ "fullyQualifiedName": "Nuke.Common.Tests",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "7bd0926acee5470b4262f22c186ca6363d475f030554e8865dd9dcfaa36cf213"
+ "equalIndicator/v1": "d26b8da2179894da4d4368625599802e8d0aa4c8a52fdbe75525f2a7a09fec36"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
"tags": [
"C#",
- ".NETStandard 2.0"
+ ".NET 6.0"
]
}
},
{
- "ruleId": "ConvertIfStatementToSwitchStatement",
+ "ruleId": "RedundantArrayCreationExpression",
"kind": "fail",
"level": "note",
"message": {
- "text": "Convert 'if' statement into 'switch'",
- "markdown": "Convert 'if' statement into 'switch'"
+ "text": "Redundant array creation expression",
+ "markdown": "Redundant array creation expression"
},
"locations": [
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/IO/AbsolutePath.cs",
+ "uri": "source/Nuke.Common.Tests/CI/ConfigurationGenerationTest.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 42,
- "startColumn": 13,
- "charOffset": 1347,
- "charLength": 2,
+ "startLine": 203,
+ "startColumn": 74,
+ "charOffset": 8435,
+ "charLength": 5,
"snippet": {
- "text": "if"
+ "text": "new[]"
},
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 40,
+ "startLine": 201,
"startColumn": 1,
- "charOffset": 1215,
- "charLength": 226,
+ "charOffset": 8201,
+ "charLength": 361,
"snippet": {
- "text": " public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object value)\n {\n if (value is string stringValue)\n {\n return HasPathRoot(stringValue)"
+ "text": " [Parameter] public readonly string[] StringArray = new[] { \"first\", \"second\" };\n [Parameter] public readonly int[] IntegerArray = new[] { 1, 2 };\n [Parameter] public readonly Configuration[] ConfigurationArray = new[] { Configuration.Debug, Configuration.Release };\n\n public AbsolutePath OutputDirectory => RootDirectory / \"output\";"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Utilities",
+ "fullyQualifiedName": "Nuke.Common.Tests",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "5afcda287550fc8aa6efc6bbda0d739f887fb3f0762c1d90dd3516959bbadb13"
+ "equalIndicator/v1": "fe04c75607792591a0a1681cceae44ad9ce4bad215840e8a2889e504efdfc166"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -105830,13 +105811,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVaultCertificate.cs",
+ "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVault.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 9,
+ "startLine": 16,
"startColumn": 1,
- "charOffset": 212,
+ "charOffset": 441,
"charLength": 1,
"snippet": {
"text": "{"
@@ -105844,12 +105825,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 7,
+ "startLine": 14,
"startColumn": 1,
- "charOffset": 169,
- "charLength": 92,
+ "charOffset": 398,
+ "charLength": 91,
"snippet": {
- "text": "\nnamespace Nuke.Common.Tools.AzureKeyVault\n{\n public class AzureKeyVaultCertificate\n {"
+ "text": "\nnamespace Nuke.Common.Tools.AzureKeyVault\n{\n [PublicAPI]\n public class AzureKeyVault"
}
}
},
@@ -105862,9 +105843,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "32ea48e74174b98dc32e550fc8ee6f1076eb8eab0117a58f09385b74166d259d"
+ "equalIndicator/v1": "59c22480c7b587d5b59d11d04db6634d162cd109eaa2962f4b015c89da9249d5"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -105886,7 +105866,7 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVaultSecretAttribute.cs",
+ "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVaultAttribute.cs",
"uriBaseId": "SRCROOT"
},
"region": {
@@ -105903,9 +105883,9 @@
"startLine": 9,
"startColumn": 1,
"charOffset": 223,
- "charLength": 202,
+ "charLength": 209,
"snippet": {
- "text": "\nnamespace Nuke.Common.Tools.AzureKeyVault\n{\n /// Attribute to obtain a secret from the Azure KeyVault defined by .\n [PublicAPI]"
+ "text": "\nnamespace Nuke.Common.Tools.AzureKeyVault\n{\n /// Attribute to obtain the KeyVault defined by to retrieve multiple items.\n [PublicAPI]"
}
}
},
@@ -105918,9 +105898,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "ea06e7a698282558f46dfdd41268bec4a0b33b9a086e7f1278283ce18d3c3aef"
+ "equalIndicator/v1": "dcb36242f2a3e13ec2f6dbb9dc3e7e4e784e9d8a22ce44a0cb82af013562638a"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -105942,13 +105921,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVaultConfigurationAttribute.cs",
+ "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVaultAttributeBase.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 13,
+ "startLine": 11,
"startColumn": 1,
- "charOffset": 315,
+ "charOffset": 271,
"charLength": 1,
"snippet": {
"text": "{"
@@ -105956,12 +105935,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 11,
+ "startLine": 9,
"startColumn": 1,
- "charOffset": 272,
- "charLength": 142,
+ "charOffset": 228,
+ "charLength": 124,
"snippet": {
- "text": "\nnamespace Nuke.Common.Tools.AzureKeyVault\n{\n /// Defines where the KeyVault login details can be found.\n [PublicAPI]"
+ "text": "\nnamespace Nuke.Common.Tools.AzureKeyVault\n{\n public abstract class AzureKeyVaultAttributeBase : ParameterAttribute\n {"
}
}
},
@@ -105974,9 +105953,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "246dcc3a13b5514e7eeca3a1006f69129a3bec4cf4acb49280211936d4d050ed"
+ "equalIndicator/v1": "ad5d3d84238e29d6a5e858706c87425bb7f01607116986d5d424c58d1c351d95"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -105998,13 +105976,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVault.cs",
+ "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVaultCertificate.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 16,
+ "startLine": 9,
"startColumn": 1,
- "charOffset": 441,
+ "charOffset": 212,
"charLength": 1,
"snippet": {
"text": "{"
@@ -106012,12 +105990,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 14,
+ "startLine": 7,
"startColumn": 1,
- "charOffset": 398,
- "charLength": 91,
+ "charOffset": 169,
+ "charLength": 92,
"snippet": {
- "text": "\nnamespace Nuke.Common.Tools.AzureKeyVault\n{\n [PublicAPI]\n public class AzureKeyVault"
+ "text": "\nnamespace Nuke.Common.Tools.AzureKeyVault\n{\n public class AzureKeyVaultCertificate\n {"
}
}
},
@@ -106030,9 +106008,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "59c22480c7b587d5b59d11d04db6634d162cd109eaa2962f4b015c89da9249d5"
+ "equalIndicator/v1": "32ea48e74174b98dc32e550fc8ee6f1076eb8eab0117a58f09385b74166d259d"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -106054,13 +106031,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVaultKey.cs",
+ "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVaultCertificateAttribute.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 10,
+ "startLine": 11,
"startColumn": 1,
- "charOffset": 248,
+ "charOffset": 266,
"charLength": 1,
"snippet": {
"text": "{"
@@ -106068,12 +106045,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 8,
+ "startLine": 9,
"startColumn": 1,
- "charOffset": 205,
- "charLength": 84,
+ "charOffset": 223,
+ "charLength": 214,
"snippet": {
- "text": "\nnamespace Nuke.Common.Tools.AzureKeyVault\n{\n public class AzureKeyVaultKey\n {"
+ "text": "\nnamespace Nuke.Common.Tools.AzureKeyVault\n{\n /// Attribute to obtain a certificates from from the Azure KeyVault defined by .\n [PublicAPI]"
}
}
},
@@ -106086,9 +106063,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "60e847d9328a099e564730d20a9c7f3e17356ad6866ff63580dfb72d9617702e"
+ "equalIndicator/v1": "e7ca777651180801303eca314666551feb42ef372c69065e23d4da8242cd638c"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -106110,13 +106086,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVaultTasks.cs",
+ "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVaultKey.cs",
"uriBaseId": "SRCROOT"
},
"region": {
"startLine": 10,
"startColumn": 1,
- "charOffset": 241,
+ "charOffset": 248,
"charLength": 1,
"snippet": {
"text": "{"
@@ -106126,10 +106102,10 @@
"contextRegion": {
"startLine": 8,
"startColumn": 1,
- "charOffset": 198,
- "charLength": 103,
+ "charOffset": 205,
+ "charLength": 84,
"snippet": {
- "text": "\nnamespace Nuke.Common.Tools.AzureKeyVault\n{\n [PublicAPI]\n public static class AzureKeyVaultTasks"
+ "text": "\nnamespace Nuke.Common.Tools.AzureKeyVault\n{\n public class AzureKeyVaultKey\n {"
}
}
},
@@ -106142,9 +106118,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "73566e6b101bc2225be94abfc186bf1228a883a341ffc8b16f1e04c5a74ccef6"
+ "equalIndicator/v1": "60e847d9328a099e564730d20a9c7f3e17356ad6866ff63580dfb72d9617702e"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -106166,7 +106141,7 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVaultCertificateAttribute.cs",
+ "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVaultKeyAttribute.cs",
"uriBaseId": "SRCROOT"
},
"region": {
@@ -106183,9 +106158,9 @@
"startLine": 9,
"startColumn": 1,
"charOffset": 223,
- "charLength": 214,
+ "charLength": 204,
"snippet": {
- "text": "\nnamespace Nuke.Common.Tools.AzureKeyVault\n{\n /// Attribute to obtain a certificates from from the Azure KeyVault defined by .\n [PublicAPI]"
+ "text": "\nnamespace Nuke.Common.Tools.AzureKeyVault\n{\n /// Attribute to obtain a key from from the Azure KeyVault defined by .\n [PublicAPI]"
}
}
},
@@ -106198,9 +106173,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "e7ca777651180801303eca314666551feb42ef372c69065e23d4da8242cd638c"
+ "equalIndicator/v1": "4915e36ccb117ece51e618248bb5ba16a668abd2bafc0ac8d788bcda145e420d"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -106222,7 +106196,7 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVaultKeyAttribute.cs",
+ "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVaultSecretAttribute.cs",
"uriBaseId": "SRCROOT"
},
"region": {
@@ -106239,9 +106213,9 @@
"startLine": 9,
"startColumn": 1,
"charOffset": 223,
- "charLength": 204,
+ "charLength": 202,
"snippet": {
- "text": "\nnamespace Nuke.Common.Tools.AzureKeyVault\n{\n /// Attribute to obtain a key from from the Azure KeyVault defined by .\n [PublicAPI]"
+ "text": "\nnamespace Nuke.Common.Tools.AzureKeyVault\n{\n /// Attribute to obtain a secret from the Azure KeyVault defined by .\n [PublicAPI]"
}
}
},
@@ -106254,9 +106228,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "4915e36ccb117ece51e618248bb5ba16a668abd2bafc0ac8d788bcda145e420d"
+ "equalIndicator/v1": "ea06e7a698282558f46dfdd41268bec4a0b33b9a086e7f1278283ce18d3c3aef"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -106278,13 +106251,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVaultAttribute.cs",
+ "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVaultConfigurationAttribute.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 11,
+ "startLine": 13,
"startColumn": 1,
- "charOffset": 266,
+ "charOffset": 315,
"charLength": 1,
"snippet": {
"text": "{"
@@ -106292,12 +106265,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 9,
+ "startLine": 11,
"startColumn": 1,
- "charOffset": 223,
- "charLength": 209,
+ "charOffset": 272,
+ "charLength": 142,
"snippet": {
- "text": "\nnamespace Nuke.Common.Tools.AzureKeyVault\n{\n /// Attribute to obtain the KeyVault defined by to retrieve multiple items.\n [PublicAPI]"
+ "text": "\nnamespace Nuke.Common.Tools.AzureKeyVault\n{\n /// Defines where the KeyVault login details can be found.\n [PublicAPI]"
}
}
},
@@ -106310,9 +106283,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "dcb36242f2a3e13ec2f6dbb9dc3e7e4e784e9d8a22ce44a0cb82af013562638a"
+ "equalIndicator/v1": "246dcc3a13b5514e7eeca3a1006f69129a3bec4cf4acb49280211936d4d050ed"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -106334,13 +106306,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVaultAttributeBase.cs",
+ "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVaultTasks.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 11,
+ "startLine": 10,
"startColumn": 1,
- "charOffset": 271,
+ "charOffset": 241,
"charLength": 1,
"snippet": {
"text": "{"
@@ -106348,12 +106320,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 9,
+ "startLine": 8,
"startColumn": 1,
- "charOffset": 228,
- "charLength": 124,
+ "charOffset": 198,
+ "charLength": 103,
"snippet": {
- "text": "\nnamespace Nuke.Common.Tools.AzureKeyVault\n{\n public abstract class AzureKeyVaultAttributeBase : ParameterAttribute\n {"
+ "text": "\nnamespace Nuke.Common.Tools.AzureKeyVault\n{\n [PublicAPI]\n public static class AzureKeyVaultTasks"
}
}
},
@@ -106366,9 +106338,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "ad5d3d84238e29d6a5e858706c87425bb7f01607116986d5d424c58d1c351d95"
+ "equalIndicator/v1": "73566e6b101bc2225be94abfc186bf1228a883a341ffc8b16f1e04c5a74ccef6"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -106424,7 +106395,6 @@
"partialFingerprints": {
"equalIndicator/v1": "c9adc2a5fc7d24ae41e4df8505fe3eee7dac0271b3addb130e259b6f29b71843"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WARNING",
"qodanaSeverity": "High",
@@ -106446,13 +106416,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/Text/String.Quoting.cs",
+ "uri": "source/Nuke.Tooling/Enumeration.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 34,
+ "startLine": 73,
"startColumn": 9,
- "charOffset": 997,
+ "charOffset": 1886,
"charLength": 2,
"snippet": {
"text": "if"
@@ -106460,27 +106430,26 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 32,
+ "startLine": 71,
"startColumn": 1,
- "charOffset": 964,
- "charLength": 88,
+ "charOffset": 1813,
+ "charLength": 172,
"snippet": {
- "text": " return str;\n\n if (!str.Contains(disallowed))\n return str;\n"
+ "text": " if (ReferenceEquals(this, obj))\n return true;\n if (obj.GetType() != GetType())\n return false;\n return Equals((Enumeration) obj);"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Utilities",
+ "fullyQualifiedName": "Nuke.Tooling",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "04bdf87b18bac919ecfdcf984051c1f41f7d2d879de93115e959b45e79da9d71"
+ "equalIndicator/v1": "65afae1557994af1f2774adfb5959118e05abf757ea11701b6307190a9851dd9"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -106502,13 +106471,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/Text/String.Quoting.cs",
+ "uri": "source/Nuke.Tooling/Enumeration.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 70,
+ "startLine": 73,
"startColumn": 9,
- "charOffset": 2081,
+ "charOffset": 1886,
"charLength": 2,
"snippet": {
"text": "if"
@@ -106516,33 +106485,32 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 68,
+ "startLine": 71,
"startColumn": 1,
- "charOffset": 2048,
- "charLength": 88,
+ "charOffset": 1813,
+ "charLength": 172,
"snippet": {
- "text": " return str;\n\n if (!str.Contains(disallowed))\n return str;\n"
+ "text": " if (ReferenceEquals(this, obj))\n return true;\n if (obj.GetType() != GetType())\n return false;\n return Equals((Enumeration) obj);"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Utilities",
+ "fullyQualifiedName": "Nuke.Tooling",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "c99bec1d06726eaf5d000bc2cea65db008b3fc57b799f84dc9c4865f38e6f171"
+ "equalIndicator/v1": "4ae1ad4f75d01a6dafc36fe9310c7b905fb64ef6d13f33c82c10c252cb6b58a0"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
"tags": [
"C#",
- ".NETStandard 2.0"
+ ".NET 6.0"
]
}
},
@@ -106558,13 +106526,68 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/Text/String.Quoting.cs",
+ "uri": "source/Nuke.Tooling/ToolResolver.cs",
"uriBaseId": "SRCROOT"
},
"region": {
+ "startLine": 36,
+ "startColumn": 9,
+ "charOffset": 1089,
+ "charLength": 2,
+ "snippet": {
+ "text": "if"
+ },
+ "sourceLanguage": "C#"
+ },
+ "contextRegion": {
"startLine": 34,
+ "startColumn": 1,
+ "charOffset": 972,
+ "charLength": 164,
+ "snippet": {
+ "text": " {\n var toolPath = ToolPathResolver.TryGetEnvironmentExecutable($\"{name.ToUpperInvariant()}_EXE\");\n if (toolPath == null)\n return null;\n"
+ }
+ }
+ },
+ "logicalLocations": [
+ {
+ "fullyQualifiedName": "Nuke.Tooling",
+ "kind": "module"
+ }
+ ]
+ }
+ ],
+ "partialFingerprints": {
+ "equalIndicator/v1": "5b2d23877d070c5e870eadb3ace4216ee554d749c8a4c135e9e09bc1d4d62c28"
+ },
+ "properties": {
+ "ideaSeverity": "WEAK WARNING",
+ "qodanaSeverity": "Moderate",
+ "tags": [
+ "C#",
+ ".NETStandard 2.0"
+ ]
+ }
+ },
+ {
+ "ruleId": "ConvertIfStatementToReturnStatement",
+ "kind": "fail",
+ "level": "note",
+ "message": {
+ "text": "Convert into 'return' statement",
+ "markdown": "Convert into 'return' statement"
+ },
+ "locations": [
+ {
+ "physicalLocation": {
+ "artifactLocation": {
+ "uri": "source/Nuke.Tooling/ToolResolver.cs",
+ "uriBaseId": "SRCROOT"
+ },
+ "region": {
+ "startLine": 36,
"startColumn": 9,
- "charOffset": 997,
+ "charOffset": 1089,
"charLength": 2,
"snippet": {
"text": "if"
@@ -106572,27 +106595,26 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 32,
+ "startLine": 34,
"startColumn": 1,
- "charOffset": 964,
- "charLength": 88,
+ "charOffset": 972,
+ "charLength": 164,
"snippet": {
- "text": " return str;\n\n if (!str.Contains(disallowed))\n return str;\n"
+ "text": " {\n var toolPath = ToolPathResolver.TryGetEnvironmentExecutable($\"{name.ToUpperInvariant()}_EXE\");\n if (toolPath == null)\n return null;\n"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Utilities",
+ "fullyQualifiedName": "Nuke.Tooling",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "ce4d94365ed59f31b34b9f9ac6459eda752e29ddf3f43aa3ed6092a96418ebc1"
+ "equalIndicator/v1": "745290234775d72ecd724135517dc431649f371852da1bdcf0a726ee6e6e67e0"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -106614,13 +106636,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/Text/String.Quoting.cs",
+ "uri": "source/Nuke.Common/CI/TeamCity/TeamCityAttribute.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 70,
- "startColumn": 9,
- "charOffset": 2081,
+ "startLine": 295,
+ "startColumn": 13,
+ "charOffset": 13517,
"charLength": 2,
"snippet": {
"text": "if"
@@ -106628,27 +106650,26 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 68,
+ "startLine": 293,
"startColumn": 1,
- "charOffset": 2048,
- "charLength": 88,
+ "charOffset": 13394,
+ "charLength": 244,
"snippet": {
- "text": " return str;\n\n if (!str.Contains(disallowed))\n return str;\n"
+ "text": " if (member.GetMemberType() == typeof(bool))\n return TeamCityParameterType.Checkbox;\n if (valueSet != null)\n return TeamCityParameterType.Select;\n return TeamCityParameterType.Text;"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Utilities",
+ "fullyQualifiedName": "Nuke.Common",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "0688e7ddd37af2c99fd42dbfd8b137c8c1657600a4b996b3b515615e8391b095"
+ "equalIndicator/v1": "973de9bb5ae5f91dd0a5eb26ca1bbb566903f33b5cd9321a80b5635963105eb3"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -106670,13 +106691,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Tooling/ToolResolver.cs",
+ "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVaultAttributeBase.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 36,
- "startColumn": 9,
- "charOffset": 1089,
+ "startLine": 23,
+ "startColumn": 13,
+ "charOffset": 691,
"charLength": 2,
"snippet": {
"text": "if"
@@ -106684,27 +106705,26 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 34,
+ "startLine": 21,
"startColumn": 1,
- "charOffset": 972,
- "charLength": 164,
+ "charOffset": 618,
+ "charLength": 129,
"snippet": {
- "text": " {\n var toolPath = ToolPathResolver.TryGetEnvironmentExecutable($\"{name.ToUpperInvariant()}_EXE\");\n if (toolPath == null)\n return null;\n"
+ "text": "\n var configuration = GetConfiguration(instance);\n if (configuration == null)\n return null;\n"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Tooling",
+ "fullyQualifiedName": "Nuke.Common",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "745290234775d72ecd724135517dc431649f371852da1bdcf0a726ee6e6e67e0"
+ "equalIndicator/v1": "e97fb6a19794967f5932a219a005c0a3aac70855006ba4ccbfe8066a3317d701"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -106726,13 +106746,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Tooling/ToolResolver.cs",
+ "uri": "source/Nuke.Build/Logging.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 36,
+ "startLine": 97,
"startColumn": 9,
- "charOffset": 1089,
+ "charOffset": 3423,
"charLength": 2,
"snippet": {
"text": "if"
@@ -106740,33 +106760,32 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 34,
+ "startLine": 95,
"startColumn": 1,
- "charOffset": 972,
- "charLength": 164,
+ "charOffset": 3285,
+ "charLength": 191,
"snippet": {
- "text": " {\n var toolPath = ToolPathResolver.TryGetEnvironmentExecutable($\"{name.ToUpperInvariant()}_EXE\");\n if (toolPath == null)\n return null;\n"
+ "text": " public static LoggerConfiguration ConfigureFilter(this LoggerConfiguration configuration, [CanBeNull] INukeBuild build)\n {\n if (build == null)\n return configuration;\n"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Tooling",
+ "fullyQualifiedName": "Nuke.Build",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "5b2d23877d070c5e870eadb3ace4216ee554d749c8a4c135e9e09bc1d4d62c28"
+ "equalIndicator/v1": "0f36989c97d30e871559281c0e2be961c7eb5b4f96dba8e77e7f777d7e6d2356"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
"tags": [
"C#",
- ".NETStandard 2.0"
+ ".NET 6.0"
]
}
},
@@ -106782,13 +106801,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/IO/PathConstruction.cs",
+ "uri": "source/Nuke.Utilities/Collections/Enumerable.Distinct.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 215,
- "startColumn": 9,
- "charOffset": 8935,
+ "startLine": 39,
+ "startColumn": 13,
+ "charOffset": 1266,
"charLength": 2,
"snippet": {
"text": "if"
@@ -106796,12 +106815,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 213,
+ "startLine": 37,
"startColumn": 1,
- "charOffset": 8860,
- "charLength": 135,
+ "charOffset": 1176,
+ "charLength": 206,
"snippet": {
- "text": " if (IsUnixRoot(left))\n return $\"{left}{right}\";\n if (IsUncRoot(left))\n return $@\"{left}\\{right}\";\n"
+ "text": " if (ReferenceEquals(y, objB: null))\n return false;\n if (x.GetType() != y.GetType())\n return false;\n return Equals(_selector(x), _selector(y));"
}
}
},
@@ -106814,9 +106833,63 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "25817576a2ef4a32bbd886c032bba85802c68512b4cbde068e572364793baad5"
+ "equalIndicator/v1": "a8f7172783c2cf9982439628557180b6db2a1256f95ac9a1efa5dbadc120724c"
+ },
+ "properties": {
+ "ideaSeverity": "WEAK WARNING",
+ "qodanaSeverity": "Moderate",
+ "tags": [
+ "C#",
+ ".NET 6.0"
+ ]
+ }
+ },
+ {
+ "ruleId": "ConvertIfStatementToReturnStatement",
+ "kind": "fail",
+ "level": "note",
+ "message": {
+ "text": "Convert into 'return' statement",
+ "markdown": "Convert into 'return' statement"
+ },
+ "locations": [
+ {
+ "physicalLocation": {
+ "artifactLocation": {
+ "uri": "source/Nuke.Utilities/Collections/Enumerable.Distinct.cs",
+ "uriBaseId": "SRCROOT"
+ },
+ "region": {
+ "startLine": 39,
+ "startColumn": 13,
+ "charOffset": 1266,
+ "charLength": 2,
+ "snippet": {
+ "text": "if"
+ },
+ "sourceLanguage": "C#"
+ },
+ "contextRegion": {
+ "startLine": 37,
+ "startColumn": 1,
+ "charOffset": 1176,
+ "charLength": 206,
+ "snippet": {
+ "text": " if (ReferenceEquals(y, objB: null))\n return false;\n if (x.GetType() != y.GetType())\n return false;\n return Equals(_selector(x), _selector(y));"
+ }
+ }
+ },
+ "logicalLocations": [
+ {
+ "fullyQualifiedName": "Nuke.Utilities",
+ "kind": "module"
+ }
+ ]
+ }
+ ],
+ "partialFingerprints": {
+ "equalIndicator/v1": "e722748591ed3b7f4b455a00bc8218c770ee141b9161f0982b83754c8b44cdd5"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -106838,13 +106911,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/IO/PathConstruction.cs",
+ "uri": "source/Nuke.Utilities/IO/AbsolutePath.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 215,
- "startColumn": 9,
- "charOffset": 8935,
+ "startLine": 49,
+ "startColumn": 13,
+ "charOffset": 1588,
"charLength": 2,
"snippet": {
"text": "if"
@@ -106852,12 +106925,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 213,
+ "startLine": 47,
"startColumn": 1,
- "charOffset": 8860,
- "charLength": 135,
+ "charOffset": 1561,
+ "charLength": 75,
"snippet": {
- "text": " if (IsUnixRoot(left))\n return $\"{left}{right}\";\n if (IsUncRoot(left))\n return $@\"{left}\\{right}\";\n"
+ "text": " }\n\n if (value is null)\n return null;\n"
}
}
},
@@ -106870,9 +106943,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "bffb37a33e814daa21953d905f0046665164b92a7be3912a4888461132270c52"
+ "equalIndicator/v1": "835f70c1b92c626eb6cb6e3d5e40e53fcc68e566dc4e267958e318970dce37c1"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -106894,13 +106966,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.GlobalTool/Rewriting/Cake/AbsolutePathRewriter.cs",
+ "uri": "source/Nuke.Utilities/IO/AbsolutePath.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 197,
+ "startLine": 139,
"startColumn": 9,
- "charOffset": 9179,
+ "charOffset": 4145,
"charLength": 2,
"snippet": {
"text": "if"
@@ -106908,27 +106980,26 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 195,
+ "startLine": 137,
"startColumn": 1,
- "charOffset": 9069,
- "charLength": 179,
+ "charOffset": 4072,
+ "charLength": 173,
"snippet": {
- "text": " {\n node = (MemberAccessExpressionSyntax) base.VisitMemberAccessExpression(node).NotNull();\n if (node.GetIdentifierName() != \"FullPath\")\n return node;\n"
+ "text": " if (ReferenceEquals(this, obj))\n return true;\n if (obj.GetType() != GetType())\n return false;\n return Equals((AbsolutePath) obj);"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.GlobalTool",
+ "fullyQualifiedName": "Nuke.Utilities",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "a3af2bc0cb0ab748e9d81ef2fa6848f8fc1baaf54e3822e685107dc567a90dac"
+ "equalIndicator/v1": "2179d0057c3d9fe9c741c3cea0ec0fcd8e119870b4e75b3204f0464824b6dccb"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -106950,13 +107021,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Build/Logging.cs",
+ "uri": "source/Nuke.Utilities/IO/AbsolutePath.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 97,
- "startColumn": 9,
- "charOffset": 3423,
+ "startLine": 49,
+ "startColumn": 13,
+ "charOffset": 1588,
"charLength": 2,
"snippet": {
"text": "if"
@@ -106964,33 +107035,32 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 95,
+ "startLine": 47,
"startColumn": 1,
- "charOffset": 3285,
- "charLength": 191,
+ "charOffset": 1561,
+ "charLength": 75,
"snippet": {
- "text": " public static LoggerConfiguration ConfigureFilter(this LoggerConfiguration configuration, [CanBeNull] INukeBuild build)\n {\n if (build == null)\n return configuration;\n"
+ "text": " }\n\n if (value is null)\n return null;\n"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Build",
+ "fullyQualifiedName": "Nuke.Utilities",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "0f36989c97d30e871559281c0e2be961c7eb5b4f96dba8e77e7f777d7e6d2356"
+ "equalIndicator/v1": "01bed548d467fd72e9b630ae7d6cdddbfe0cd59f0126ad0cc8be0ca95feb281a"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
"tags": [
"C#",
- ".NET 6.0"
+ ".NETStandard 2.0"
]
}
},
@@ -107006,13 +107076,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/Text/String.Escape.cs",
+ "uri": "source/Nuke.Utilities/IO/AbsolutePath.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 16,
+ "startLine": 139,
"startColumn": 9,
- "charOffset": 372,
+ "charOffset": 4145,
"charLength": 2,
"snippet": {
"text": "if"
@@ -107020,12 +107090,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 14,
+ "startLine": 137,
"startColumn": 1,
- "charOffset": 291,
- "charLength": 150,
+ "charOffset": 4072,
+ "charLength": 173,
"snippet": {
- "text": " public static string EscapeBraces([CanBeNull] this string str)\n {\n if (string.IsNullOrWhiteSpace(str))\n return string.Empty;\n"
+ "text": " if (ReferenceEquals(this, obj))\n return true;\n if (obj.GetType() != GetType())\n return false;\n return Equals((AbsolutePath) obj);"
}
}
},
@@ -107038,9 +107108,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "c6b8e5208fdd626d89bfaa648169c6078fb29c4a6eb461975eeec807bbfb979d"
+ "equalIndicator/v1": "85be0da3db64c62462fa4730c329a413a1f05927e773274c01be2c7af8699eb0"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -107062,13 +107131,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/Text/String.Escape.cs",
+ "uri": "source/Nuke.Utilities/IO/PathConstruction.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 16,
+ "startLine": 215,
"startColumn": 9,
- "charOffset": 372,
+ "charOffset": 8935,
"charLength": 2,
"snippet": {
"text": "if"
@@ -107076,12 +107145,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 14,
+ "startLine": 213,
"startColumn": 1,
- "charOffset": 291,
- "charLength": 150,
+ "charOffset": 8860,
+ "charLength": 135,
"snippet": {
- "text": " public static string EscapeBraces([CanBeNull] this string str)\n {\n if (string.IsNullOrWhiteSpace(str))\n return string.Empty;\n"
+ "text": " if (IsUnixRoot(left))\n return $\"{left}{right}\";\n if (IsUncRoot(left))\n return $@\"{left}\\{right}\";\n"
}
}
},
@@ -107094,9 +107163,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "1fbcb5028c64583720132c00053aeca4b264b7c027dea5e65d870a33a4f648bb"
+ "equalIndicator/v1": "bffb37a33e814daa21953d905f0046665164b92a7be3912a4888461132270c52"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -107118,13 +107186,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Tooling.Generator/Model/IDeprecatable.cs",
+ "uri": "source/Nuke.Utilities/IO/RelativePath.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 33,
+ "startLine": 32,
"startColumn": 9,
- "charOffset": 818,
+ "charOffset": 804,
"charLength": 2,
"snippet": {
"text": "if"
@@ -107132,33 +107200,32 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 31,
+ "startLine": 30,
"startColumn": 1,
- "charOffset": 749,
- "charLength": 193,
+ "charOffset": 716,
+ "charLength": 131,
"snippet": {
- "text": " {\n var message = deprecatable.DeprecationMessage;\n if (!string.IsNullOrEmpty(message))\n return message;\n return deprecatable.Parent?.GetDeprecationMessage();"
+ "text": " public static explicit operator RelativePath([CanBeNull] string path)\n {\n if (path is null)\n return null;\n"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Tooling.Generator",
+ "fullyQualifiedName": "Nuke.Utilities",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "3f95de911ee49862006bfe31c0221c4dc4ee9d4d0d3b8db7fd589ee93cde1ab7"
+ "equalIndicator/v1": "c4dc4f8d8816051be3ae9490c5885252ee853a974c2f00eaeaa1edfbe3843a56"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
"tags": [
"C#",
- ".NETStandard 2.0"
+ ".NET 6.0"
]
}
},
@@ -107174,13 +107241,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/Collections/Enumerable.Distinct.cs",
+ "uri": "source/Nuke.Utilities/IO/RelativePath.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 39,
- "startColumn": 13,
- "charOffset": 1266,
+ "startLine": 32,
+ "startColumn": 9,
+ "charOffset": 804,
"charLength": 2,
"snippet": {
"text": "if"
@@ -107188,12 +107255,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 37,
+ "startLine": 30,
"startColumn": 1,
- "charOffset": 1176,
- "charLength": 206,
+ "charOffset": 716,
+ "charLength": 131,
"snippet": {
- "text": " if (ReferenceEquals(y, objB: null))\n return false;\n if (x.GetType() != y.GetType())\n return false;\n return Equals(_selector(x), _selector(y));"
+ "text": " public static explicit operator RelativePath([CanBeNull] string path)\n {\n if (path is null)\n return null;\n"
}
}
},
@@ -107206,9 +107273,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "e722748591ed3b7f4b455a00bc8218c770ee141b9161f0982b83754c8b44cdd5"
+ "equalIndicator/v1": "9018b0abfc2a7a21bf64823a3c3c41dd6506161d9da3cb09d3faa02ae5810a38"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -107230,13 +107296,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/Collections/Enumerable.Distinct.cs",
+ "uri": "source/Nuke.Utilities/IO/PathConstruction.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 39,
- "startColumn": 13,
- "charOffset": 1266,
+ "startLine": 215,
+ "startColumn": 9,
+ "charOffset": 8935,
"charLength": 2,
"snippet": {
"text": "if"
@@ -107244,12 +107310,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 37,
+ "startLine": 213,
"startColumn": 1,
- "charOffset": 1176,
- "charLength": 206,
+ "charOffset": 8860,
+ "charLength": 135,
"snippet": {
- "text": " if (ReferenceEquals(y, objB: null))\n return false;\n if (x.GetType() != y.GetType())\n return false;\n return Equals(_selector(x), _selector(y));"
+ "text": " if (IsUnixRoot(left))\n return $\"{left}{right}\";\n if (IsUncRoot(left))\n return $@\"{left}\\{right}\";\n"
}
}
},
@@ -107262,15 +107328,14 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "a8f7172783c2cf9982439628557180b6db2a1256f95ac9a1efa5dbadc120724c"
+ "equalIndicator/v1": "25817576a2ef4a32bbd886c032bba85802c68512b4cbde068e572364793baad5"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
"tags": [
"C#",
- ".NET 6.0"
+ ".NETStandard 2.0"
]
}
},
@@ -107286,13 +107351,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.GlobalTool/Rewriting/Cake/FormattingRewriter.cs",
+ "uri": "source/Nuke.Utilities/Reflection/ReflectionUtility.DisplayText.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 42,
+ "startLine": 86,
"startColumn": 9,
- "charOffset": 1684,
+ "charOffset": 3133,
"charLength": 2,
"snippet": {
"text": "if"
@@ -107300,27 +107365,26 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 40,
+ "startLine": 84,
"startColumn": 1,
- "charOffset": 1591,
- "charLength": 230,
+ "charOffset": 3114,
+ "charLength": 155,
"snippet": {
- "text": " return token.WithLeadingTrivia(LineFeed.Concat(Indent).Concat(Indent));\n\n if (identifierName.StartsWith(\"Set\"))\n return token.WithLeadingTrivia(LineFeed.Concat(Indent).Concat(Indent).Concat(Indent));\n"
+ "text": " }\n\n if (type.IsArray)\n return $\"{type.GetElementType().GetDisplayShortName(tupleNames)}[{','.Repeat(type.GetArrayRank() - 1)}]\";\n"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.GlobalTool",
+ "fullyQualifiedName": "Nuke.Utilities",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "178932f4d4054ffef4c72e15f4b281d27c62a65b7dd5650f67213d78838639d0"
+ "equalIndicator/v1": "901b2c43cc1c453c0343725706a61b1fe926d1566e4da0b31aeee6aa1b42d61d"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -107342,13 +107406,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.GlobalTool/Program.cs",
+ "uri": "source/Nuke.Utilities/Reflection/ReflectionUtility.DisplayText.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 60,
+ "startLine": 86,
"startColumn": 9,
- "charOffset": 1701,
+ "charOffset": 3133,
"charLength": 2,
"snippet": {
"text": "if"
@@ -107356,33 +107420,32 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 58,
+ "startLine": 84,
"startColumn": 1,
- "charOffset": 1657,
- "charLength": 179,
+ "charOffset": 3114,
+ "charLength": 155,
"snippet": {
- "text": " return parameterValue;\n\n if (EnvironmentInfo.GetNamedArgument(Constants.RootDirectoryParameterName))\n return EnvironmentInfo.WorkingDirectory;\n"
+ "text": " }\n\n if (type.IsArray)\n return $\"{type.GetElementType().GetDisplayShortName(tupleNames)}[{','.Repeat(type.GetArrayRank() - 1)}]\";\n"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.GlobalTool",
+ "fullyQualifiedName": "Nuke.Utilities",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "29e164cfb8c5b68eacd482831b765ef3656a97d348fe9abb20d86158aea46e1f"
+ "equalIndicator/v1": "36ea9f0b84467e79fb1fff4230d2d982d5854ac334e4ccdb23d3c6e9d5f13dbd"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
"tags": [
"C#",
- ".NET 6.0"
+ ".NETStandard 2.0"
]
}
},
@@ -107398,13 +107461,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Tooling/Enumeration.cs",
+ "uri": "source/Nuke.Utilities/Text/String.Escape.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 73,
+ "startLine": 16,
"startColumn": 9,
- "charOffset": 1886,
+ "charOffset": 372,
"charLength": 2,
"snippet": {
"text": "if"
@@ -107412,27 +107475,26 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 71,
+ "startLine": 14,
"startColumn": 1,
- "charOffset": 1813,
- "charLength": 172,
+ "charOffset": 291,
+ "charLength": 150,
"snippet": {
- "text": " if (ReferenceEquals(this, obj))\n return true;\n if (obj.GetType() != GetType())\n return false;\n return Equals((Enumeration) obj);"
+ "text": " public static string EscapeBraces([CanBeNull] this string str)\n {\n if (string.IsNullOrWhiteSpace(str))\n return string.Empty;\n"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Tooling",
+ "fullyQualifiedName": "Nuke.Utilities",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "4ae1ad4f75d01a6dafc36fe9310c7b905fb64ef6d13f33c82c10c252cb6b58a0"
+ "equalIndicator/v1": "1fbcb5028c64583720132c00053aeca4b264b7c027dea5e65d870a33a4f648bb"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -107454,69 +107516,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Tooling/Enumeration.cs",
- "uriBaseId": "SRCROOT"
- },
- "region": {
- "startLine": 73,
- "startColumn": 9,
- "charOffset": 1886,
- "charLength": 2,
- "snippet": {
- "text": "if"
- },
- "sourceLanguage": "C#"
- },
- "contextRegion": {
- "startLine": 71,
- "startColumn": 1,
- "charOffset": 1813,
- "charLength": 172,
- "snippet": {
- "text": " if (ReferenceEquals(this, obj))\n return true;\n if (obj.GetType() != GetType())\n return false;\n return Equals((Enumeration) obj);"
- }
- }
- },
- "logicalLocations": [
- {
- "fullyQualifiedName": "Nuke.Tooling",
- "kind": "module"
- }
- ]
- }
- ],
- "partialFingerprints": {
- "equalIndicator/v1": "65afae1557994af1f2774adfb5959118e05abf757ea11701b6307190a9851dd9"
- },
- "baselineState": "unchanged",
- "properties": {
- "ideaSeverity": "WEAK WARNING",
- "qodanaSeverity": "Moderate",
- "tags": [
- "C#",
- ".NETStandard 2.0"
- ]
- }
- },
- {
- "ruleId": "ConvertIfStatementToReturnStatement",
- "kind": "fail",
- "level": "note",
- "message": {
- "text": "Convert into 'return' statement",
- "markdown": "Convert into 'return' statement"
- },
- "locations": [
- {
- "physicalLocation": {
- "artifactLocation": {
- "uri": "source/Nuke.Utilities/IO/RelativePath.cs",
+ "uri": "source/Nuke.Utilities/Text/String.Escape.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 32,
+ "startLine": 16,
"startColumn": 9,
- "charOffset": 804,
+ "charOffset": 372,
"charLength": 2,
"snippet": {
"text": "if"
@@ -107524,12 +107530,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 30,
+ "startLine": 14,
"startColumn": 1,
- "charOffset": 716,
- "charLength": 131,
+ "charOffset": 291,
+ "charLength": 150,
"snippet": {
- "text": " public static explicit operator RelativePath([CanBeNull] string path)\n {\n if (path is null)\n return null;\n"
+ "text": " public static string EscapeBraces([CanBeNull] this string str)\n {\n if (string.IsNullOrWhiteSpace(str))\n return string.Empty;\n"
}
}
},
@@ -107542,9 +107548,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "9018b0abfc2a7a21bf64823a3c3c41dd6506161d9da3cb09d3faa02ae5810a38"
+ "equalIndicator/v1": "c6b8e5208fdd626d89bfaa648169c6078fb29c4a6eb461975eeec807bbfb979d"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -107566,13 +107571,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/IO/RelativePath.cs",
+ "uri": "source/Nuke.Utilities/Text/String.Quoting.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 32,
+ "startLine": 34,
"startColumn": 9,
- "charOffset": 804,
+ "charOffset": 997,
"charLength": 2,
"snippet": {
"text": "if"
@@ -107580,12 +107585,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 30,
+ "startLine": 32,
"startColumn": 1,
- "charOffset": 716,
- "charLength": 131,
+ "charOffset": 964,
+ "charLength": 88,
"snippet": {
- "text": " public static explicit operator RelativePath([CanBeNull] string path)\n {\n if (path is null)\n return null;\n"
+ "text": " return str;\n\n if (!str.Contains(disallowed))\n return str;\n"
}
}
},
@@ -107598,9 +107603,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "c4dc4f8d8816051be3ae9490c5885252ee853a974c2f00eaeaa1edfbe3843a56"
+ "equalIndicator/v1": "ce4d94365ed59f31b34b9f9ac6459eda752e29ddf3f43aa3ed6092a96418ebc1"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -107622,13 +107626,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Common/CI/TeamCity/TeamCityAttribute.cs",
+ "uri": "source/Nuke.Utilities/Text/String.Quoting.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 295,
- "startColumn": 13,
- "charOffset": 13517,
+ "startLine": 70,
+ "startColumn": 9,
+ "charOffset": 2081,
"charLength": 2,
"snippet": {
"text": "if"
@@ -107636,27 +107640,26 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 293,
+ "startLine": 68,
"startColumn": 1,
- "charOffset": 13394,
- "charLength": 244,
+ "charOffset": 2048,
+ "charLength": 88,
"snippet": {
- "text": " if (member.GetMemberType() == typeof(bool))\n return TeamCityParameterType.Checkbox;\n if (valueSet != null)\n return TeamCityParameterType.Select;\n return TeamCityParameterType.Text;"
+ "text": " return str;\n\n if (!str.Contains(disallowed))\n return str;\n"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Common",
+ "fullyQualifiedName": "Nuke.Utilities",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "973de9bb5ae5f91dd0a5eb26ca1bbb566903f33b5cd9321a80b5635963105eb3"
+ "equalIndicator/v1": "0688e7ddd37af2c99fd42dbfd8b137c8c1657600a4b996b3b515615e8391b095"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -107678,13 +107681,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/Reflection/ReflectionUtility.DisplayText.cs",
+ "uri": "source/Nuke.Utilities/Text/String.Quoting.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 86,
+ "startLine": 34,
"startColumn": 9,
- "charOffset": 3133,
+ "charOffset": 997,
"charLength": 2,
"snippet": {
"text": "if"
@@ -107692,12 +107695,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 84,
+ "startLine": 32,
"startColumn": 1,
- "charOffset": 3114,
- "charLength": 155,
+ "charOffset": 964,
+ "charLength": 88,
"snippet": {
- "text": " }\n\n if (type.IsArray)\n return $\"{type.GetElementType().GetDisplayShortName(tupleNames)}[{','.Repeat(type.GetArrayRank() - 1)}]\";\n"
+ "text": " return str;\n\n if (!str.Contains(disallowed))\n return str;\n"
}
}
},
@@ -107710,9 +107713,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "36ea9f0b84467e79fb1fff4230d2d982d5854ac334e4ccdb23d3c6e9d5f13dbd"
+ "equalIndicator/v1": "04bdf87b18bac919ecfdcf984051c1f41f7d2d879de93115e959b45e79da9d71"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -107734,13 +107736,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/Reflection/ReflectionUtility.DisplayText.cs",
+ "uri": "source/Nuke.Utilities/Text/String.Quoting.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 86,
+ "startLine": 70,
"startColumn": 9,
- "charOffset": 3133,
+ "charOffset": 2081,
"charLength": 2,
"snippet": {
"text": "if"
@@ -107748,12 +107750,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 84,
+ "startLine": 68,
"startColumn": 1,
- "charOffset": 3114,
- "charLength": 155,
+ "charOffset": 2048,
+ "charLength": 88,
"snippet": {
- "text": " }\n\n if (type.IsArray)\n return $\"{type.GetElementType().GetDisplayShortName(tupleNames)}[{','.Repeat(type.GetArrayRank() - 1)}]\";\n"
+ "text": " return str;\n\n if (!str.Contains(disallowed))\n return str;\n"
}
}
},
@@ -107766,15 +107768,14 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "901b2c43cc1c453c0343725706a61b1fe926d1566e4da0b31aeee6aa1b42d61d"
+ "equalIndicator/v1": "c99bec1d06726eaf5d000bc2cea65db008b3fc57b799f84dc9c4865f38e6f171"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
"tags": [
"C#",
- ".NET 6.0"
+ ".NETStandard 2.0"
]
}
},
@@ -107790,13 +107791,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/IO/AbsolutePath.cs",
+ "uri": "source/Nuke.Utilities/EnvironmentInfo.Platform.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 49,
+ "startLine": 103,
"startColumn": 13,
- "charOffset": 1588,
+ "charOffset": 2912,
"charLength": 2,
"snippet": {
"text": "if"
@@ -107804,12 +107805,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 47,
+ "startLine": 101,
"startColumn": 1,
- "charOffset": 1561,
- "charLength": 75,
+ "charOffset": 2854,
+ "charLength": 162,
"snippet": {
- "text": " }\n\n if (value is null)\n return null;\n"
+ "text": " return PlatformFamily.Linux;\n\n if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))\n return PlatformFamily.Windows;\n"
}
}
},
@@ -107822,15 +107823,14 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "01bed548d467fd72e9b630ae7d6cdddbfe0cd59f0126ad0cc8be0ca95feb281a"
+ "equalIndicator/v1": "44f5a9f15f5d6b8772f042485e53e5e9d825118d233e56e42ca058bfd8bf9b20"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
"tags": [
"C#",
- ".NETStandard 2.0"
+ ".NET 6.0"
]
}
},
@@ -107846,13 +107846,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/IO/AbsolutePath.cs",
+ "uri": "source/Nuke.Utilities/EnvironmentInfo.Platform.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 139,
- "startColumn": 9,
- "charOffset": 4145,
+ "startLine": 103,
+ "startColumn": 13,
+ "charOffset": 2912,
"charLength": 2,
"snippet": {
"text": "if"
@@ -107860,12 +107860,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 137,
+ "startLine": 101,
"startColumn": 1,
- "charOffset": 4072,
- "charLength": 173,
+ "charOffset": 2854,
+ "charLength": 162,
"snippet": {
- "text": " if (ReferenceEquals(this, obj))\n return true;\n if (obj.GetType() != GetType())\n return false;\n return Equals((AbsolutePath) obj);"
+ "text": " return PlatformFamily.Linux;\n\n if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))\n return PlatformFamily.Windows;\n"
}
}
},
@@ -107878,9 +107878,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "85be0da3db64c62462fa4730c329a413a1f05927e773274c01be2c7af8699eb0"
+ "equalIndicator/v1": "7e2d283d530537d309c79706f62859d3bcea7394cbd9d2cb877c982e26c29d87"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -107902,13 +107901,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/IO/AbsolutePath.cs",
+ "uri": "source/Nuke.GlobalTool/Rewriting/Cake/AbsolutePathRewriter.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 49,
- "startColumn": 13,
- "charOffset": 1588,
+ "startLine": 197,
+ "startColumn": 9,
+ "charOffset": 9179,
"charLength": 2,
"snippet": {
"text": "if"
@@ -107916,27 +107915,26 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 47,
+ "startLine": 195,
"startColumn": 1,
- "charOffset": 1561,
- "charLength": 75,
+ "charOffset": 9069,
+ "charLength": 179,
"snippet": {
- "text": " }\n\n if (value is null)\n return null;\n"
+ "text": " {\n node = (MemberAccessExpressionSyntax) base.VisitMemberAccessExpression(node).NotNull();\n if (node.GetIdentifierName() != \"FullPath\")\n return node;\n"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Utilities",
+ "fullyQualifiedName": "Nuke.GlobalTool",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "835f70c1b92c626eb6cb6e3d5e40e53fcc68e566dc4e267958e318970dce37c1"
+ "equalIndicator/v1": "a3af2bc0cb0ab748e9d81ef2fa6848f8fc1baaf54e3822e685107dc567a90dac"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -107958,13 +107956,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/IO/AbsolutePath.cs",
+ "uri": "source/Nuke.GlobalTool/Rewriting/Cake/FormattingRewriter.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 139,
+ "startLine": 42,
"startColumn": 9,
- "charOffset": 4145,
+ "charOffset": 1684,
"charLength": 2,
"snippet": {
"text": "if"
@@ -107972,27 +107970,26 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 137,
+ "startLine": 40,
"startColumn": 1,
- "charOffset": 4072,
- "charLength": 173,
+ "charOffset": 1591,
+ "charLength": 230,
"snippet": {
- "text": " if (ReferenceEquals(this, obj))\n return true;\n if (obj.GetType() != GetType())\n return false;\n return Equals((AbsolutePath) obj);"
+ "text": " return token.WithLeadingTrivia(LineFeed.Concat(Indent).Concat(Indent));\n\n if (identifierName.StartsWith(\"Set\"))\n return token.WithLeadingTrivia(LineFeed.Concat(Indent).Concat(Indent).Concat(Indent));\n"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Utilities",
+ "fullyQualifiedName": "Nuke.GlobalTool",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "2179d0057c3d9fe9c741c3cea0ec0fcd8e119870b4e75b3204f0464824b6dccb"
+ "equalIndicator/v1": "178932f4d4054ffef4c72e15f4b281d27c62a65b7dd5650f67213d78838639d0"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -108014,13 +108011,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Common/Tools/AzureKeyVault/AzureKeyVaultAttributeBase.cs",
+ "uri": "source/Nuke.GlobalTool/Program.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 23,
- "startColumn": 13,
- "charOffset": 691,
+ "startLine": 60,
+ "startColumn": 9,
+ "charOffset": 1701,
"charLength": 2,
"snippet": {
"text": "if"
@@ -108028,27 +108025,26 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 21,
+ "startLine": 58,
"startColumn": 1,
- "charOffset": 618,
- "charLength": 129,
+ "charOffset": 1657,
+ "charLength": 179,
"snippet": {
- "text": "\n var configuration = GetConfiguration(instance);\n if (configuration == null)\n return null;\n"
+ "text": " return parameterValue;\n\n if (EnvironmentInfo.GetNamedArgument(Constants.RootDirectoryParameterName))\n return EnvironmentInfo.WorkingDirectory;\n"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Common",
+ "fullyQualifiedName": "Nuke.GlobalTool",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "e97fb6a19794967f5932a219a005c0a3aac70855006ba4ccbfe8066a3317d701"
+ "equalIndicator/v1": "29e164cfb8c5b68eacd482831b765ef3656a97d348fe9abb20d86158aea46e1f"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -108070,13 +108066,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/EnvironmentInfo.Platform.cs",
+ "uri": "source/Nuke.Tooling.Generator/Model/IDeprecatable.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 103,
- "startColumn": 13,
- "charOffset": 2912,
+ "startLine": 33,
+ "startColumn": 9,
+ "charOffset": 818,
"charLength": 2,
"snippet": {
"text": "if"
@@ -108084,27 +108080,26 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 101,
+ "startLine": 31,
"startColumn": 1,
- "charOffset": 2854,
- "charLength": 162,
+ "charOffset": 749,
+ "charLength": 193,
"snippet": {
- "text": " return PlatformFamily.Linux;\n\n if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))\n return PlatformFamily.Windows;\n"
+ "text": " {\n var message = deprecatable.DeprecationMessage;\n if (!string.IsNullOrEmpty(message))\n return message;\n return deprecatable.Parent?.GetDeprecationMessage();"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Utilities",
+ "fullyQualifiedName": "Nuke.Tooling.Generator",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "7e2d283d530537d309c79706f62859d3bcea7394cbd9d2cb877c982e26c29d87"
+ "equalIndicator/v1": "3f95de911ee49862006bfe31c0221c4dc4ee9d4d0d3b8db7fd589ee93cde1ab7"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -108115,52 +108110,51 @@
}
},
{
- "ruleId": "ConvertIfStatementToReturnStatement",
+ "ruleId": "SwitchStatementHandlesSomeKnownEnumValuesWithDefault",
"kind": "fail",
"level": "note",
"message": {
- "text": "Convert into 'return' statement",
- "markdown": "Convert into 'return' statement"
+ "text": "Some cases are not processed: default",
+ "markdown": "Some cases are not processed: default"
},
"locations": [
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Utilities/EnvironmentInfo.Platform.cs",
+ "uri": "source/Nuke.Common/Tools/Docker/DockerTasks.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 103,
- "startColumn": 13,
- "charOffset": 2912,
- "charLength": 2,
+ "startLine": 16,
+ "startColumn": 9,
+ "charOffset": 361,
+ "charLength": 6,
"snippet": {
- "text": "if"
+ "text": "switch"
},
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 101,
+ "startLine": 14,
"startColumn": 1,
- "charOffset": 2854,
- "charLength": 162,
+ "charOffset": 277,
+ "charLength": 140,
"snippet": {
- "text": " return PlatformFamily.Linux;\n\n if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))\n return PlatformFamily.Windows;\n"
+ "text": " internal static void CustomLogger(OutputType type, string output)\n {\n switch (type)\n {\n case OutputType.Std:"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Utilities",
+ "fullyQualifiedName": "Nuke.Common",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "44f5a9f15f5d6b8772f042485e53e5e9d825118d233e56e42ca058bfd8bf9b20"
+ "equalIndicator/v1": "71a24868873c7203090f1d5b743e3f315dd4cba4a2f73540a0364d059e9da752"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -108182,13 +108176,13 @@
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Common/Tools/Docker/DockerTasks.cs",
+ "uri": "source/Nuke.Common/Tools/Npm/NpmTasks.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 16,
+ "startLine": 14,
"startColumn": 9,
- "charOffset": 361,
+ "charOffset": 320,
"charLength": 6,
"snippet": {
"text": "switch"
@@ -108196,12 +108190,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 14,
+ "startLine": 12,
"startColumn": 1,
- "charOffset": 277,
- "charLength": 140,
+ "charOffset": 238,
+ "charLength": 138,
"snippet": {
- "text": " internal static void CustomLogger(OutputType type, string output)\n {\n switch (type)\n {\n case OutputType.Std:"
+ "text": " public static void CustomLogger(OutputType type, string output)\n {\n switch (type)\n {\n case OutputType.Std:"
}
}
},
@@ -108214,9 +108208,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "71a24868873c7203090f1d5b743e3f315dd4cba4a2f73540a0364d059e9da752"
+ "equalIndicator/v1": "84a4452b7c97113345ac071c9a641389523c1d157844239c71f16cd890eed8bd"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -108242,9 +108235,9 @@
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 16,
+ "startLine": 49,
"startColumn": 9,
- "charOffset": 363,
+ "charOffset": 1595,
"charLength": 6,
"snippet": {
"text": "switch"
@@ -108252,12 +108245,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 14,
+ "startLine": 47,
"startColumn": 1,
- "charOffset": 298,
- "charLength": 145,
+ "charOffset": 1528,
+ "charLength": 147,
"snippet": {
- "text": " public static void DeletePassword(string name)\n {\n switch (EnvironmentInfo.Platform)\n {\n case PlatformFamily.OSX:"
+ "text": " public static string TryGetPassword(string name)\n {\n switch (EnvironmentInfo.Platform)\n {\n case PlatformFamily.OSX:"
}
}
},
@@ -108270,9 +108263,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "3bbf1dea4c8ffc7b9a5301495f4ab819555cf32239a5c0e22784aad081214191"
+ "equalIndicator/v1": "96828da770a49ad9490a76dcd9388e764f2ecb53c9f143a981f11a5ed0c175e3"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -108328,7 +108320,6 @@
"partialFingerprints": {
"equalIndicator/v1": "074c3c0bb92eb7ae5f8d64edb6495c79ce6a2e66d32abb5349963f58d22e1284"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -108354,9 +108345,9 @@
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 49,
+ "startLine": 16,
"startColumn": 9,
- "charOffset": 1595,
+ "charOffset": 363,
"charLength": 6,
"snippet": {
"text": "switch"
@@ -108364,12 +108355,12 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 47,
+ "startLine": 14,
"startColumn": 1,
- "charOffset": 1528,
- "charLength": 147,
+ "charOffset": 298,
+ "charLength": 145,
"snippet": {
- "text": " public static string TryGetPassword(string name)\n {\n switch (EnvironmentInfo.Platform)\n {\n case PlatformFamily.OSX:"
+ "text": " public static void DeletePassword(string name)\n {\n switch (EnvironmentInfo.Platform)\n {\n case PlatformFamily.OSX:"
}
}
},
@@ -108382,9 +108373,8 @@
}
],
"partialFingerprints": {
- "equalIndicator/v1": "96828da770a49ad9490a76dcd9388e764f2ecb53c9f143a981f11a5ed0c175e3"
+ "equalIndicator/v1": "3bbf1dea4c8ffc7b9a5301495f4ab819555cf32239a5c0e22784aad081214191"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -108399,20 +108389,20 @@
"kind": "fail",
"level": "note",
"message": {
- "text": "Some cases are not processed: default",
- "markdown": "Some cases are not processed: default"
+ "text": "Some values of the enum are not processed inside switch: None, Scheduled, Running",
+ "markdown": "Some values of the enum are not processed inside switch: None, Scheduled, Running"
},
"locations": [
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Common/Tools/Npm/NpmTasks.cs",
+ "uri": "source/Nuke.Build/Host.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 14,
- "startColumn": 9,
- "charOffset": 320,
+ "startLine": 136,
+ "startColumn": 13,
+ "charOffset": 4970,
"charLength": 6,
"snippet": {
"text": "switch"
@@ -108420,27 +108410,26 @@
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 12,
+ "startLine": 134,
"startColumn": 1,
- "charOffset": 238,
- "charLength": 138,
+ "charOffset": 4822,
+ "charLength": 230,
"snippet": {
- "text": " public static void CustomLogger(OutputType type, string output)\n {\n switch (type)\n {\n case OutputType.Std:"
+ "text": " {\n var line = CreateLine(target.Name, target.Status.ToString(), GetDurationOrBlank(target), GetInformation(target));\n switch (target.Status)\n {\n case ExecutionStatus.Skipped:"
}
}
},
"logicalLocations": [
{
- "fullyQualifiedName": "Nuke.Common",
+ "fullyQualifiedName": "Nuke.Build",
"kind": "module"
}
]
}
],
"partialFingerprints": {
- "equalIndicator/v1": "84a4452b7c97113345ac071c9a641389523c1d157844239c71f16cd890eed8bd"
+ "equalIndicator/v1": "40f15a4a31d8c71fbbdd2fd9598839b9f863955c27db16e09a54506a35033f24"
},
- "baselineState": "unchanged",
"properties": {
"ideaSeverity": "WEAK WARNING",
"qodanaSeverity": "Moderate",
@@ -108451,55 +108440,109 @@
}
},
{
- "ruleId": "SwitchStatementHandlesSomeKnownEnumValuesWithDefault",
+ "ruleId": "AutoPropertyCanBeMadeGetOnly.Local",
"kind": "fail",
- "level": "note",
+ "level": "warning",
"message": {
- "text": "Some values of the enum are not processed inside switch: None, Scheduled, Running",
- "markdown": "Some values of the enum are not processed inside switch: None, Scheduled, Running"
+ "text": "Auto-property can be made get-only",
+ "markdown": "Auto-property can be made get-only"
},
"locations": [
{
"physicalLocation": {
"artifactLocation": {
- "uri": "source/Nuke.Build/Host.cs",
+ "uri": "source/Nuke.Tooling/Process2.cs",
"uriBaseId": "SRCROOT"
},
"region": {
- "startLine": 136,
- "startColumn": 13,
- "charOffset": 4970,
- "charLength": 6,
+ "startLine": 32,
+ "startColumn": 54,
+ "charOffset": 957,
+ "charLength": 12,
"snippet": {
- "text": "switch"
+ "text": "private set;"
},
"sourceLanguage": "C#"
},
"contextRegion": {
- "startLine": 134,
+ "startLine": 30,
"startColumn": 1,
- "charOffset": 4822,
- "charLength": 230,
+ "charOffset": 828,
+ "charLength": 190,
"snippet": {
- "text": " {\n var line = CreateLine(target.Name, target.Status.ToString(), GetDurationOrBlank(target), GetInformation(target));\n switch (target.Status)\n {\n case ExecutionStatus.Skipped:"
+ "text": " public string WorkingDirectory => _process.StartInfo.WorkingDirectory;\n\n public IReadOnlyCollection