Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serde serialization rework #94

Merged
merged 5 commits into from
Jul 31, 2022
Merged

Serde serialization rework #94

merged 5 commits into from
Jul 31, 2022

Conversation

fjarri
Copy link
Contributor

@fjarri fjarri commented Jul 3, 2022

This is the foundation needed for nucypher/nucypher-core#17

  • Add 0x to hex-encoded bytestrings.
  • Expose the bytes/hex/base64 serialization machinery (as serde_bytes module) so that nucypher-core could use it instead of serde_bytes crate and its own arrays_as_bytes.

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2022

Codecov Report

Merging #94 (b10de46) into master (8138b5b) will decrease coverage by 0.33%.
The diff coverage is 75.30%.

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   60.31%   59.98%   -0.34%     
==========================================
  Files          17       17              
  Lines        1449     1472      +23     
==========================================
+ Hits          874      883       +9     
- Misses        575      589      +14     
Impacted Files Coverage Δ
umbral-pre/src/traits.rs 76.66% <ø> (ø)
umbral-pre/src/serde_bytes.rs 69.69% <69.69%> (ø)
umbral-pre/src/capsule.rs 91.26% <100.00%> (ø)
umbral-pre/src/capsule_frag.rs 88.19% <100.00%> (ø)
umbral-pre/src/key_frag.rs 90.05% <100.00%> (+0.11%) ⬆️
umbral-pre/src/keys.rs 77.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8138b5b...b10de46. Read the comment docs.

Copy link
Contributor

@piotr-roslaniec piotr-roslaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Would you say it mandates a major version bump?

@fjarri fjarri merged commit c586bab into nucypher:master Jul 31, 2022
@fjarri fjarri deleted the hex-prefix branch July 31, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants