[WIP] Peer Snitching Contract #248
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cygnusv
reviewed
Apr 5, 2024
contracts/contracts/TACoEvidence.sol
Outdated
| collection.endTimestamp = collection.initTimestamp + submissionWindow; | ||
| collection.nonce = | ||
| uint256(keccak256(abi.encodePacked(block.timestamp, block.difficulty))) % | ||
| 10 ** 18; |
There was a problem hiding this comment.
Why mod 10^18? Unless there's a good reason, I'd drop it.
contracts/contracts/TACoEvidence.sol
Outdated
| } | ||
|
|
||
| // Function for nodes to submit their online status with evidence | ||
| function submitEvidence(uint32 id, bytes[] memory signatures, address[] memory peers) public { |
There was a problem hiding this comment.
I'd remove the peers parameter, and simply extract the operator address (as you currently do in L85), and then cross-check with the staking provider address.
contracts/contracts/TACoEvidence.sol
Outdated
|
|
||
| ITACoChildApplication public immutable application; | ||
|
|
||
| uint256 public submissionWindow = 1 hours; |
There was a problem hiding this comment.
This can probably be made immutable.
contracts/contracts/TACoEvidence.sol
Outdated
| Collection[] public collections; | ||
|
|
||
| constructor() { | ||
| admin = msg.sender; |
There was a problem hiding this comment.
This isn't defined, right? Anyway, I'd define as immutable too.
There was a problem hiding this comment.
I'd change it to Ownable and owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews: