Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit rounding strategies during reward calculation #260

Open
cygnusv opened this issue May 3, 2024 · 0 comments
Open

Revisit rounding strategies during reward calculation #260

cygnusv opened this issue May 3, 2024 · 0 comments

Comments

@cygnusv
Copy link
Member

cygnusv commented May 3, 2024

From GH (#254 (comment)):

Vicky:  now I see your question, but I didn't do that on purpose, reason is it could produce different result because of rounding errors, for all other places it's division first and then addition/subtraction.

Continuing discussion on Discord:

David:  re: rounding errors, in general, addition & subtraction before division would yield less rounding errors
Vicky:  But it will produce different errors, and easily it will create authorizedOverall different to sum of authorized
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cygnusv