Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Temperature inputs are hard to read #8

Closed
AlexSwensen opened this issue Mar 31, 2017 · 7 comments
Closed

Temperature inputs are hard to read #8

AlexSwensen opened this issue Mar 31, 2017 · 7 comments

Comments

@AlexSwensen
Copy link

AlexSwensen commented Mar 31, 2017

All inputs (and selects) should probably have a style applied to them that is easy to read in all cases.
Currently its hard to read (most notably the temperature inputs).

I can work on a PR to solve this if you like

@ntoff
Copy link
Owner

ntoff commented Mar 31, 2017

I'll take a look at it. The inputs are black text on white while you're editing them but yeah most of the time they're a dull grey colour and I guess might be a bit hard to see. Weirdly, all the inputs in the settings dialog seem to be fine.

@ntoff
Copy link
Owner

ntoff commented Mar 31, 2017

ok I've made some changes: 633784f

edit: image of what it looks like now in chrome. Placeholder text is darker

image

@AlexSwensen I'm sorry but there's no auto update in place, you'll have to uninstall and then reinstall the plugin to update it.

Incidentally, that "impossible to read" behaviour is standard for the theme https://bootswatch.com/2/cyborg/ as that text is meant to be placeholder text (and as such should be nearly impossible to read), it seems octoprint is using placeholder text as actual text. @foosel :(

@AlexSwensen
Copy link
Author

Cool. I'll check this out. Sadly i'll be traveling through the weekend, but when i get back i'll test out the new version. While placeholder text has subtle differences, it should be distinct enough for most of us to be able to read. (as is demonstrated in the link you posted)

Your screenshot does look much better though. I'll post feedback once i have had an opportunity to test.

Regarding updates, should be possible to solve for that soon as well. More than happy to look into this with you.

@ntoff
Copy link
Owner

ntoff commented Mar 31, 2017

really? the placeholder text in the link to the actual cyborg theme source is nearly invisible to me. I guess different monitors render it differently.

Either way it should hopefully be fixed now, been having trouble with my dev pc so hopefully if THAT's also fixed, maybe I'll look into the releases and auto updates stuff. I'm not a programmer by trade and all this github stuff is sort of confusing to me.

@AlexSwensen
Copy link
Author

AlexSwensen commented Mar 31, 2017

I can see the text perfectly fine in your screenshot and your link on my Macbook Pro, so it should be fine for many users.

Regarding github, if that becomes an issue I'm happy to pitch in. OctoPrint really needs a nice dark theme, and I'm happy to contribute where i can.

@ntoff
Copy link
Owner

ntoff commented Mar 31, 2017

Thanks, and yeah I didn't realise how much I wanted a dark theme until a request for one popped up. It really helps for those late night print jobs, not being blinded by the bright white page.

I'll leave the honour of closing this up to you once you've tested it (if the changes are satisfactory). I've tested it on my PC and on an android tablet and it seems ok, the only macbook I have access to is pre-retina so I doubt it'd render much differently to my PC.

@AlexSwensen
Copy link
Author

Looks good! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants