Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 4.0 #1

Open
GTNT-Github opened this issue Sep 7, 2023 · 8 comments
Open

Update to 4.0 #1

GTNT-Github opened this issue Sep 7, 2023 · 8 comments

Comments

@GTNT-Github
Copy link

Are there any plans to update this plugin to Godot 4.0?

@Mastermori
Copy link

Mastermori commented Sep 24, 2023

I am not the author of this plugin but I need this very much. I will fork this repo and update it to 4.0 as soon as I have the time (sometime next week).
We will see if @nsrosenqvist will accept a pull request for that update.
This plugin is also gone from the asset library for some reason, if it's not added back I will probably add the updated fork to it (no promises).
Edit: nvm, just stayed up late to port this right now. You can find my fork of it here. Will polish it some more tomorrow and add an Interface class to extend from instead of adding comments to work around 4.x restrictions.
I also think that this fork will deviate too far from the original code, so a pull request is probably not useful.

@nsrosenqvist
Copy link
Owner

@Mastermori @GTNT-Github sorry, I missed this issue. I'd gladly accept the PR if you ported it @Mastermori! I can check the asset library regarding why it's disappeared, I hadn't noticed this but will investigate today

@nsrosenqvist
Copy link
Owner

@Mastermori it appears to still be listed in the asset library. Perhaps it doesn't show for 4.x without the 4.0 tag? I'll add it when I merge your PR

@argumentus
Copy link

Hello, @nsrosenqvist.

Could you please tell me if a plugin has been added to the asset for godot version 4.*?

@nsrosenqvist
Copy link
Owner

@argumentus I have not ported it, and I haven't heard anything from @Mastermori either. The code is really quite simple and lightweight, so it shouldn't be hard to do. Please fork and submit a pull request if you decide to do it and I'll gladly accept the PR.

@Mastermori
Copy link

Mastermori commented Nov 21, 2023

Oh sorry, I kind of forgot about this.
I ported it to 4.0 the same night I wrote the first comment and just uploaded it to the asset store myself, so I could use it easily on my other devices.
There were some issues with porting to 4.0 as some of Godots functionality changed and you can no longer access global class_names as consts. Therefore the plugin will be a lot less performant (see the explanation in the updated readme). I will try to create a PR by the end of today.

@Mastermori
Copy link

I have now created a PR: #2, should I remove my extension from the store so you can upload yours again or do you want to link mine?

@nsrosenqvist
Copy link
Owner

@Mastermori I will check if the store can point to different branches, so that we could keep code for 4.x and 3.x in the same repo, I think that would make it easier for users. I wouldn't mind sharing maintainership of the repo either if you'd like to help with that. Will get back to you after the weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants