nsqadmin: statsd prefix 'stats_counts' is outdated, but hardcoded

[kesutton]

I just installed NSQ 0.3.5, and was looking forward to the graphite integration. I am using the built-in statsd power of nsqd, and that is working great. However, it looks like nsqadmin is failing because of the statsd prefix "stats_counts". According to this site: https://github.com/etsy/statsd/blob/master/docs/graphite.md, "stats_counts" is outdated, in favor of "stats.counters". This is similar for gauges.

It would be nice to have the counters/gauges statsd prefix field be configurable, so nsqadmin will integrate with newer versions of statsd. Right now I believe it is hardcoded here:

nsq/nsqadmin/static/js/lib/handlebars_helpers.js

Line 15 in 2a8dab2

prefix = 'stats_counts.' + prefix;

[kesutton]

I actually overlooked this -

nsq/nsqadmin/static/js/lib/handlebars_helpers.js

Line 17 in 2a8dab2

prefix = 'stats.gauges.' + prefix;

The gauges prefix is already correct as "stats.gauges", so it is just stats.counters that would be configurable (or updated)

[mreiferson]

@kesutton I highly recommend disabling statsd's built in prefixes but I think we would merge a change to update that line to stats.counts.

Want to to open a PR?

[kesutton]

What do you mean disabling statsd's built in prefixes? I don't think that is possible in statsd, otherwise you wouldn't know the difference between a "counter" and a "gauge". You can change those prefixes, as specified here: https://github.com/etsy/statsd/blob/master/docs/namespacing.md. That could be a workaround for this situation by modifying "prefixCounter" to "stats_counts", but that would make the stats hierarchy uneven.

Or did you mean turning off nsqadmin's "use_statsd_prefixes"? If I did that, then the stats wouldn't work at all, because then nsqadmin would be looking in graphite for stats that start with the nsq stats prefix ("nsq.%s"), of which there are no stats since statsd always (I thought) puts some prefix in there.

Please advise.

I'd be happy to open a PR.

[kesutton]

Also, do you want PRs against the "master" or "dev" branch? Looks like dev is behind. I'll make it to master and change if you need.

[mreiferson]

Looking at this document it looks like you can just use empty strings for all the prefixes?

Or you can use something like statsdaemon.

Finally, it looks like if you set legacyNamespace to true you'll get the keys under the right namespace for the current state of NSQ, stats_counts.

[mreiferson]

"fixed" in #656