Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Consider config reload on SIGHUP #200

Closed
alexvanin opened this issue Sep 6, 2022 · 0 comments · Fixed by #201
Closed

Consider config reload on SIGHUP #200

alexvanin opened this issue Sep 6, 2022 · 0 comments · Fixed by #201
Assignees
Labels
good first issue Good for newcomers U3 Regular
Milestone

Comments

@alexvanin
Copy link
Contributor

alexvanin commented Sep 6, 2022

It will be nice to reload and update app on the go.

Reload whole app

The easiest way is to restart application and therefore re-read config. This is acceptable but we don't want to close all connections and terminate all sessions. So consider more innocent approach

Reload some config sections

  • 🔴 Update wallet: key is used in the client, not sure we can safely re-read that
  • 🟢 Restart pprof + metrics servers
  • 🟢 Update logger config
  • 🟡 Update cert files: if possible without server termination
  • 🔴 Update NeoFS peers: pretty sure it is not possible. Consider weight update feature issue in SDK.
  • 🟡 Update buffer sizes: if possible without server termination
  • 🟢 Update resolve order
  • 🔴 Update pool timers: pretty sure it is not possible. Consider feature issue in SDK.
  • 🟢 Timestamp header parameter
  • 🟢 Enable / disable compression

Check if all 🟢 sections are re-readable.
Investigate 🟡 sections
Discuss if 🔴 sections are mandatory to update without restart /cc @realloc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers U3 Regular
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants