Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: add decimals/name/symbol data to getNEPXXBalance #2581

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

roman-khimov
Copy link
Member

@roman-khimov roman-khimov added this to the v0.99.1 milestone Jul 4, 2022
@roman-khimov roman-khimov requested a review from AnnaShaleva July 4, 2022 14:14
@roman-khimov roman-khimov added the rpc RPC server and client label Jul 4, 2022
@roman-khimov roman-khimov force-pushed the sym-dec-in-getnep17balances branch from f947fc1 to c356c14 Compare July 4, 2022 15:28
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #2581 (c356c14) into master (039fcda) will increase coverage by 0.03%.
The diff coverage is 52.11%.

@@            Coverage Diff             @@
##           master    #2581      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.03%     
==========================================
  Files         297      297              
  Lines       37259    37304      +45     
==========================================
+ Hits        31632    31683      +51     
+ Misses       4278     4260      -18     
- Partials     1349     1361      +12     
Impacted Files Coverage Δ
pkg/network/server_config.go 100.00% <ø> (ø)
pkg/rpc/server/server.go 76.28% <52.11%> (-1.06%) ⬇️
cli/smartcontract/smart_contract.go 92.17% <0.00%> (-0.37%) ⬇️
pkg/core/native/management.go 92.39% <0.00%> (+0.01%) ⬆️
pkg/network/message.go 96.26% <0.00%> (+0.74%) ⬆️
pkg/services/oracle/request.go 63.01% <0.00%> (+5.02%) ⬆️
pkg/network/message_string.go 83.87% <0.00%> (+6.45%) ⬆️
pkg/core/transaction/signer.go 87.50% <0.00%> (+12.50%) ⬆️
pkg/services/oracle/oracle.go 88.37% <0.00%> (+15.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4afdb9f...c356c14. Read the comment docs.

@roman-khimov roman-khimov merged commit 2ba9017 into master Jul 5, 2022
@roman-khimov roman-khimov deleted the sym-dec-in-getnep17balances branch July 5, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc RPC server and client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants