feat(eslint): rename eslint.config.js to eslint.config.cjs to resolve them as CommonJS #29334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your CI Pipeline Execution ↗ for commit f27e9c6 ⏳ is in progress.
Last updated at 2024-12-13 21:49:06UTC Sent with 💌 from NxCloud. |
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
from
144e881 to
0fa0b93
Compare
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
from
0fa0b93 to
224a3ee
Compare
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
from
224a3ee to
29bb7fe
Compare
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
4 times, most recently
from
4506885 to
b6aa8af
Compare
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
from
b6aa8af to
5d373e1
Compare
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
from
5d373e1 to
3126725
Compare
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
from
3126725 to
053838f
Compare
…e resolved as CommonJS
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
from
053838f to
f27e9c6
Compare
AgentEnder
approved these changes
Dec 13, 2024
JamesHenry
reviewed
Dec 14, 2024
| @@ -51,7 +51,7 @@ export function updateFilesForRootProjects( | |||
| if (!allowedExt.includes(ext)) { | |||
| continue; | |||
| } | |||
| if (file === '.eslintrc.json' || file === 'eslint.config.js') { | |||
| if (file === '.eslintrc.json' || file === 'eslint.config.cjs') { | |||
There was a problem hiding this comment.
Why was this one a replacement when others were applied in addition to the existing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our generators to use
eslint.config.cjsinstead ofeslint.config.jsso that Node resolution will treat it as CommonJS. This solves an issue where having"type": "module"inpackage.jsonwill result in an error when Node tries to resolve the config file as ESM.Also allows us to clean up out Remix generators to not have to rename to
eslint.config.cjsto solve the same issue.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #