Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): not exit when one plugin installation failed #28684

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Oct 29, 2024

Current Behavior

it tries to install all plugins at once. if failed, it will stop the remaining plugins from being installed.

Expected Behavior

it will continue if one plugin failed.

success message:
Screenshot 2024-12-11 at 11 36 14 AM
failed message:
Screenshot 2024-12-12 at 2 58 17 PM

Related Issue(s)

Fixes #

@xiongemi xiongemi requested a review from a team as a code owner October 29, 2024 20:50
@xiongemi xiongemi requested a review from FrozenPandaz October 29, 2024 20:50
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 5:16pm

Copy link

nx-cloud bot commented Oct 29, 2024

Your CI Pipeline Execution ↗ for commit 8246f20 ⏳ is in progress.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 10m, 53s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 22s View ↗
nx-cloud record -- nx format:check --base=48cd5... ✅ Succeeded 2s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 0s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 0s View ↗
nx documentation --no-dte ✅ Succeeded 0s View ↗

Last updated at 2024-12-13 22:09:47UTC

Sent with 💌 from NxCloud.

@xiongemi xiongemi force-pushed the fix/fix-not-failed-plugin-install-failed branch 5 times, most recently from 0e95cc4 to 5f68e6d Compare November 10, 2024 22:31
@xiongemi xiongemi force-pushed the fix/fix-not-failed-plugin-install-failed branch from 5f68e6d to 55b3501 Compare November 21, 2024 08:00
@xiongemi xiongemi requested review from a team as code owners November 21, 2024 08:00
@xiongemi xiongemi force-pushed the fix/fix-not-failed-plugin-install-failed branch from 55b3501 to adf7155 Compare November 21, 2024 17:14
@xiongemi xiongemi force-pushed the fix/fix-not-failed-plugin-install-failed branch from adf7155 to 4960194 Compare November 21, 2024 18:13
@xiongemi xiongemi force-pushed the fix/fix-not-failed-plugin-install-failed branch 3 times, most recently from 403b8c7 to 45e14d7 Compare November 28, 2024 23:54
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a Loom for this one as well.

packages/nx/src/command-line/init/configure-plugins.ts Outdated Show resolved Hide resolved
@xiongemi xiongemi force-pushed the fix/fix-not-failed-plugin-install-failed branch 2 times, most recently from 8e53a6a to 50d0dd7 Compare December 7, 2024 20:05
@xiongemi xiongemi force-pushed the fix/fix-not-failed-plugin-install-failed branch 7 times, most recently from d489434 to fd0bf2b Compare December 10, 2024 22:43
@xiongemi xiongemi force-pushed the fix/fix-not-failed-plugin-install-failed branch 5 times, most recently from 07d8593 to 75c19f3 Compare December 13, 2024 15:17
@xiongemi xiongemi force-pushed the fix/fix-not-failed-plugin-install-failed branch from 75c19f3 to 8246f20 Compare December 13, 2024 17:12
@xiongemi xiongemi requested a review from a team as a code owner December 13, 2024 17:12
@xiongemi xiongemi requested a review from JamesHenry December 13, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants