-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): not exit when one plugin installation failed #28684
Open
xiongemi
wants to merge
1
commit into
master
Choose a base branch
from
fix/fix-not-failed-plugin-install-failed
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+402
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Your CI Pipeline Execution ↗ for commit 8246f20 ⏳ is in progress.
Last updated at 2024-12-13 22:09:47UTC Sent with 💌 from NxCloud. |
FrozenPandaz
requested changes
Nov 6, 2024
xiongemi
force-pushed
the
fix/fix-not-failed-plugin-install-failed
branch
5 times, most recently
from
November 10, 2024 22:31
0e95cc4
to
5f68e6d
Compare
xiongemi
force-pushed
the
fix/fix-not-failed-plugin-install-failed
branch
from
November 21, 2024 08:00
5f68e6d
to
55b3501
Compare
xiongemi
force-pushed
the
fix/fix-not-failed-plugin-install-failed
branch
from
November 21, 2024 17:14
55b3501
to
adf7155
Compare
xiongemi
force-pushed
the
fix/fix-not-failed-plugin-install-failed
branch
from
November 21, 2024 18:13
adf7155
to
4960194
Compare
xiongemi
force-pushed
the
fix/fix-not-failed-plugin-install-failed
branch
3 times, most recently
from
November 28, 2024 23:54
403b8c7
to
45e14d7
Compare
FrozenPandaz
requested changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a Loom for this one as well.
xiongemi
force-pushed
the
fix/fix-not-failed-plugin-install-failed
branch
2 times, most recently
from
December 7, 2024 20:05
8e53a6a
to
50d0dd7
Compare
xiongemi
force-pushed
the
fix/fix-not-failed-plugin-install-failed
branch
7 times, most recently
from
December 10, 2024 22:43
d489434
to
fd0bf2b
Compare
FrozenPandaz
requested changes
Dec 11, 2024
xiongemi
force-pushed
the
fix/fix-not-failed-plugin-install-failed
branch
5 times, most recently
from
December 13, 2024 15:17
07d8593
to
75c19f3
Compare
xiongemi
force-pushed
the
fix/fix-not-failed-plugin-install-failed
branch
from
December 13, 2024 17:12
75c19f3
to
8246f20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
it tries to install all plugins at once. if failed, it will stop the remaining plugins from being installed.
Expected Behavior
it will continue if one plugin failed.
success message:
failed message:
Related Issue(s)
Fixes #