-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(testing): move jest config to .ts files #9854
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/919Tcygkye5vMrHW2dzoPA8dFzA6 |
ea496f3
to
abb0a0a
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
18722be
to
20a3358
Compare
33ec42a
to
9a20106
Compare
running some local migrations there looks to be some issue with updating the jest.config.js when there is a spread operator. > NX Running migrations from 'migrations.json'
Running migration update-jest-config-extensions
> NX Please manually update nx-dev/ui-member-card/jest.config.js
Could not automatically remove the 'preset' property from nx-dev/ui-member-card/jest.config.js:
> NX Please manually update nx-dev/ui-member-card/jest.config.js
Could not automatically add the following property to nx-dev/ui-member-card/jest.config.js:
preset: "../../jest.preset.ts"
Error: Cannot read properties of undefined (reading 'getText')
> NX Please manually update nx-dev/ui-sponsor-card/jest.config.js
Could not automatically remove the 'preset' property from nx-dev/ui-sponsor-card/jest.config.js:
> NX Please manually update nx-dev/ui-sponsor-card/jest.config.js
Could not automatically add the following property to nx-dev/ui-sponsor-card/jest.config.js:
preset: "../../jest.preset.ts"
Error: Cannot read properties of undefined (reading 'getText')
Successfully finished update-jest-config-extensions |
9a20106
to
5df1413
Compare
move jest config and preset to ts files ISSUES CLOSED: #8344
update tests broken by renaming jest fils to ts files
5df1413
to
fb40831
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
move jest config and preset to ts files
Current Behavior
nx creates js files for jest config/preset
Expected Behavior
nx should create ts files for the configs/preset instead of js files
Related Issue(s)
Fixes #8344