Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): expose mfe package helpers #9781

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Apr 11, 2022

Current Behavior

We have not exposed the sharePackages and shareWorkspaceLibraries helpers from @nrwl/angular.

Expected Behavior

We should expose those helpers to allow people to begin to use them in scenarios where they have a more involved webpack.config.js and cannot use withModuleFederation

@Coly010 Coly010 requested a review from leosvelperez April 11, 2022 10:01
@Coly010 Coly010 self-assigned this Apr 11, 2022
@nx-cloud
Copy link

nx-cloud bot commented Apr 11, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8fcb768. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 11 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/EnxBbcxJqutnRp1NBEf6nvUKnofr
✅ Preview: Ignored

@Coly010 Coly010 merged commit 7839ed0 into nrwl:master Apr 11, 2022
@Coly010 Coly010 deleted the angular/expose-mfe-helpers branch April 11, 2022 10:36
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants