feat(angular): allow migrating angular cli workspaces using the @angular-eslint/builder:lint builder #9750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/5ELdQxE7HN1U6fDjgYjPDQ5pXHiU [Deployment for 43888cd canceled] |
leosvelperez
force-pushed
the
angular/ng-add-eslint-support
branch
from
2ab768f to
c2d72a5
Compare
leosvelperez
force-pushed
the
angular/ng-add-eslint-support
branch
from
c2d72a5 to
f5b3ab0
Compare
Coly010
approved these changes
Apr 11, 2022
packages/angular/src/generators/ng-add/migrate-from-angular-cli.ts
Outdated
Show resolved
Hide resolved
packages/angular/src/generators/ng-add/utilities/app.migrator.ts
Outdated
Show resolved
Hide resolved
packages/angular/src/generators/ng-add/utilities/app.migrator.ts
Outdated
Show resolved
Hide resolved
packages/angular/src/generators/ng-add/utilities/app.migrator.ts
Outdated
Show resolved
Hide resolved
packages/angular/src/generators/ng-add/utilities/e2e-project.migrator.ts
Show resolved
Hide resolved
packages/angular/src/generators/ng-add/utilities/e2e-project.migrator.ts
Show resolved
Hide resolved
packages/angular/src/generators/ng-add/utilities/e2e-project.migrator.ts
Show resolved
Hide resolved
leosvelperez
force-pushed
the
angular/ng-add-eslint-support
branch
from
f5b3ab0 to
aeb47e5
Compare
leosvelperez
force-pushed
the
angular/ng-add-eslint-support
branch
from
aeb47e5 to
9c50799
Compare
…lar-eslint/builder:lint builder
leosvelperez
force-pushed
the
angular/ng-add-eslint-support
branch
from
9c50799 to
43888cd
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Angular CLI workspaces can't be migrated when using the
@angular-eslint/builder:lintbuilder. The generator to migrate is still looking for TSLint configuration that's no longer generated or supported.Expected Behavior
Angular CLI workspaces using ESLint with the
@angular-eslint/builder:lintbuilder can be migrated.Related Issue(s)
Fixes #