Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misc): do not add typescript or @nrwl/cli during add nx to monorepo #9736

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

We add @nrwl/cli and typescript during add-nx-to-monorepo

Expected Behavior

@nrwl/cli is not necessary anymore so we won't add it.

typescript is not our responsibility to add so we won't add it.

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Apr 7, 2022

@vercel
Copy link

vercel bot commented Apr 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/9ftypaXJm2ZXDYSZjKDTSbfUzST6
✅ Preview: Ignored

@FrozenPandaz FrozenPandaz merged commit bbb0841 into nrwl:master Apr 8, 2022
@FrozenPandaz FrozenPandaz deleted the do-not-add-typescript branch April 8, 2022 19:57
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant