fix(core): replaceAppNameWithPath should not consider additional properties #9706

[Coly010]

Current Behavior

The util function replaces the appName with the path to the app. It ignores certain properties that should not be replaced.
defaultConfiguration and maximumError is not one of those properties.

If an app is called dev then it will have issues if the defaultConfiguration is development and it will replace it with a path.

maximumError conflicts with app names containing mb etc.

Expected Behavior

Do not consider defaultConfiguration or maximumError when replacing app name with path

Related Issue(s)

Fixes #9706

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3837632. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 6 targets

• nx affected --target=build --base=a64bba9980cf8f37a2febf54aa52015adb7cff3c --head=3837632442b8101ece7a28cd1cc2454524278470 --parallel=3
• nx affected --target=e2e --base=a64bba9980cf8f37a2febf54aa52015adb7cff3c --head=3837632442b8101ece7a28cd1cc2454524278470 --exclude=e2e-detox,e2e-js,e2e-next,e2e-workspace-create,e2e-workspace-integrations,e2e-workspace-core,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-cli,e2e-nx-plugin,e2e-cypress,e2e-node,e2e-linter,e2e-jest,e2e-a...
• nx affected --target=e2e --base=a64bba9980cf8f37a2febf54aa52015adb7cff3c --head=3837632442b8101ece7a28cd1cc2454524278470 --exclude=e2e-storybook,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=lint --base=a64bba9980cf8f37a2febf54aa52015adb7cff3c --head=3837632442b8101ece7a28cd1cc2454524278470 --parallel=3
• nx affected --target=test --base=a64bba9980cf8f37a2febf54aa52015adb7cff3c --head=3837632442b8101ece7a28cd1cc2454524278470 --parallel=1
• nx build typedoc-theme

---

Sent with 💌 from NxCloud.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/3wZxfH3weA6YXzBBtpSFf6rCSEF6
✅ Preview: Canceled

[Deployment for 3837632 canceled]

[AgentEnder]

@Coly010 Should maximumError be added to the list as well? That is the specific key that was an issue in the linked ticket.

[Coly010]

It should! good catch. They did mention that key, I missed that. I focused on the serve error which was caused by default configuration

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.