Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot set experimentalDecorators: false for @nx/angular:ng-packagr-lite builder #26448

Closed
1 of 4 tasks
MillerSvt opened this issue Jun 7, 2024 · 3 comments · Fixed by #26691
Closed
1 of 4 tasks

Cannot set experimentalDecorators: false for @nx/angular:ng-packagr-lite builder #26448

MillerSvt opened this issue Jun 7, 2024 · 3 comments · Fixed by #26691
Assignees
@leosvelperez
Labels
outdated scope: angular Issues related to Angular support in Nx type: bug

Comments

@MillerSvt
Copy link

Current Behavior

"experimentalDecorators": false,
"emitDecoratorMetadata": false

this options are ignored

Expected Behavior

this options enables new ECMA Decorators

GitHub Repo

No response

Steps to Reproduce

  1. nx g @nx/angular:library --name=libs/modern-decorators-lib --buildable
  2. change former options in tsconfig.json
  3. create and apply some ECMA decorator in new lib
  4. build

Nx Report

Node   : 20.12.2
OS     : darwin-arm64
npm    : 10.5.0

nx                 : 19.2.1
@nx/js             : 19.2.1
@nx/jest           : 19.2.1
@nx/linter         : 19.2.1
@nx/eslint         : 19.2.1
@nx/workspace      : 19.2.1
@nx/angular        : 19.2.1
@nx/devkit         : 19.2.1
@nx/eslint-plugin  : 19.2.1
@nrwl/tao          : 19.2.1
@nx/web            : 19.2.1
@nx/webpack        : 19.2.1
typescript         : 5.4.5

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

The problem is inside readDefaultTsConfig (node_modules/@nx/angular/src/executors/utilities/typescript.js). This function overrides experimentalDecorators option from my tsconfig.
@MillerSvt
Copy link
Author

Temporary workaround:
Change executor from '@nx/angular:ng-packagr-lite' to '@angular-devkit/build-angular:ng-packagr'

@FrozenPandaz FrozenPandaz added the scope: angular Issues related to Angular support in Nx label Jun 7, 2024
@MillerSvt
Copy link
Author

any news here?

@leosvelperez leosvelperez mentioned this issue Jun 26, 2024
Merged
FrozenPandaz pushed a commit that referenced this issue Jun 26, 2024
@leosvelperez @FrozenPandaz
fix(angular): allow usages of ecmascript decorators in ng-packagr exe…
c7cb8da 
…cutors (#26691)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #26448

(cherry picked from commit a871643)
@github-actions GitHub Actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@leosvelperez leosvelperez

Labels
outdated scope: angular Issues related to Angular support in Nx type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(angular): allow usages of ecmascript decorators in ng-packagr executors nrwl/nx
3 participants
@FrozenPandaz @leosvelperez @MillerSvt