Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bun as package manager #21154

Closed
1 task done
ffMathy opened this issue Jan 16, 2024 · 2 comments
Closed
1 task done

Bun as package manager #21154

ffMathy opened this issue Jan 16, 2024 · 2 comments

Comments

@ffMathy
Copy link

ffMathy commented Jan 16, 2024

Description, Motivation, Suggested implementation

Before you close this, please hear me out.

In #11049, it was mentioned that making NX support for Bun as a package manager would require changes to the core.

That's true, but since Bun's lock file is identical to Yarn's (it's a binary file), it wouldn't require many changes, and most likely wouldn't lead to a lot of trouble and bugs.

In fact, a guy named Jordan Hall even made a patch to support it: https://gist.github.com/Jordan-Hall/e910402a31b4a1e5a0b78324d6595618

I feel like the Bun related issues are closed way too fast. Yes, I know there's a discussion available, but is that being tracked or monitored? I feel like locking an issue keeps us from counting the amount of up votes on it.

Here, I'm not advocating towards full Bun support in NX. However, just support for the package manager part.

I also feel like the impact is huge. I already tested the performance boost of Bun compared to even pnpm. And it's very, very real. So for such a huge win with such an easy change (as highlighted in the patch), what's not to like?

If you decide to lock this, at least please post a proper reasoning around your thoughts, and perhaps give the community a chance to provide a counter argument to that reasoning.

Bun is not just hype it seems. I get different vibes than when Yarn came out. The places where I've tried using it, the difference was night and day, and the Node team doesn't seem to be responding at all to Bun's competition.

@AgentEnder
Copy link
Member

We can leave an issue open for now for Bun, its just not a priority at this moment so support it automatically. You should still be able to use bun for installing packages, and just use the --skip-install flags for generators and set NX_MIGRATE_SKIP_INSTALL when migrating, as then Nx shouldn't ever be running a package manager install.

For now, I'm closing this out in favor of #21075, which will track bun support.

Copy link

github-actions bot commented Mar 4, 2024

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants