Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Ensure build-custom-server is only added once to nx.json #18972

Merged

Conversation

ndcunningham
Copy link
Contributor

This PR fixes the issue of when creating a new Next.js project with the --custom-server flag it will be only added once to nx.json's cacheableOperations

closes: #18957

@ndcunningham ndcunningham added the scope: nextjs Issues related to NextJS support for Nx label Sep 1, 2023
@ndcunningham ndcunningham self-assigned this Sep 1, 2023
@ndcunningham ndcunningham requested a review from a team as a code owner September 1, 2023 17:46
@vercel
Copy link

vercel bot commented Sep 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 5:46pm

@jaysoo jaysoo merged commit b42be17 into nrwl:master Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: nextjs Issues related to NextJS support for Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nx/next keeps adding 'build-custom-server' to cacheableOperations multiple times
2 participants