-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nx-dev): get the correct query for ai feedback #18961
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mandarini
force-pushed
the
feat/chat-msg-uid
branch
from
September 1, 2023 07:41
9cfcb7d
to
8f5b8e5
Compare
mandarini
changed the title
feat(nx-dev): get the correct question for feedback
feat(nx-dev): get the correct query for ai feedback
Sep 1, 2023
FrozenPandaz
approved these changes
Sep 1, 2023
mandarini
force-pushed
the
feat/chat-msg-uid
branch
from
September 1, 2023 13:53
8f5b8e5
to
3f496a3
Compare
isaacplmann
approved these changes
Sep 1, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We have a list of messages, and each one has an index, which is generated by the loop that renders the messages. The messages are Queries (by the user) and Responses (by the assistant).
The 👍 / 👎 feedback buttons are "attached" to the Response message. So, whenever a user clicks on the feedback button, we know that they clicked on the message with index
X
. Using that indexX
we assume that the Query that resulted in that Response is the message with indexX-1
. Since this logic is based on an assumption that the messages list will always be consistent and "correct" and sorted, we think that it is brittle.Expected Behavior
Now that we use the
useChat
fromai/react
package, we get back a list of messages, and each message has its ownid
. So, when we get a Response, we tie theid
of the Response with the Query that gave that Response. That way, we can be sure that when a user clicks the feedback button, their feedback will be for the correct Query.@bcabanes