Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): set external nodes when lockfile is not reprocessed #18944

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

@FrozenPandaz FrozenPandaz commented Aug 31, 2023

Current Behavior

The lockfile is not reprocessed when a different version of nx processes the file.

Expected Behavior

The lockfile should be reprocessed when different versions of nx process the file.

Also when the lockfile isn't processed, the right external nodes should still be considered when processing dependencies.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Aug 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 31, 2023 8:01pm

@FrozenPandaz FrozenPandaz force-pushed the fix-js-plugin branch 2 times, most recently from 1a282a3 to faa6f84 Compare August 31, 2023 19:00
@FrozenPandaz FrozenPandaz marked this pull request as ready for review August 31, 2023 19:19
@FrozenPandaz FrozenPandaz requested a review from a team as a code owner August 31, 2023 19:19
@FrozenPandaz FrozenPandaz enabled auto-merge (squash) August 31, 2023 19:20
@FrozenPandaz FrozenPandaz merged commit 7f76c2b into nrwl:master Aug 31, 2023
@FrozenPandaz FrozenPandaz deleted the fix-js-plugin branch August 31, 2023 21:13
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants