Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): use production build for static-serve for MF #18942

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Aug 31, 2023

Current Behavior

We currently use development build configuration when serving the static file-server for remotes.
As this uses the development configuration, there's a strong chance that no cache currently exists for these remotes.

Expected Behavior

Switch to production build configuration when serving the static file-server for remotes.

The result is two-fold:

  1. Increased probability of cache hits as CI will produce cache that can be used.
  2. These remotes that are served statically are supposed to emulate the real remote. They're not intended to be changed and worked on during local dev. They do not need to be served in development, and it is more correct and accurate to serve them as production.

Related Issue(s)

Fixes #

@Coly010 Coly010 requested review from a team as code owners August 31, 2023 14:23
@Coly010 Coly010 requested a review from jaysoo August 31, 2023 14:23
@Coly010 Coly010 self-assigned this Aug 31, 2023
@vercel
Copy link

vercel bot commented Aug 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 31, 2023 2:24pm

@Coly010 Coly010 merged commit 60da797 into nrwl:master Sep 1, 2023
@Coly010 Coly010 deleted the mf/use-production-for-static-serve branch September 1, 2023 13:29
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants