feat(core): ensure @nx/js plugin is installed for all JS workspaces #18919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
FrozenPandaz
requested changes
Aug 30, 2023
jaysoo
force-pushed
the
feat/ensure-js-plugin
branch
from
16af98e to
aaf96f1
Compare
jaysoo
force-pushed
the
feat/ensure-js-plugin
branch
from
aaf96f1 to
5c660e0
Compare
jaysoo
commented
Aug 30, 2023
| @@ -759,7 +759,7 @@ describe('Workspace Tests', () => { | |||
|
|
|||
| expect(error).toBeDefined(); | |||
| expect(error.stdout.toString()).toContain( | |||
| `${lib1} is still depended on by the following projects` | |||
There was a problem hiding this comment.
This is failing due to changes here 70d3728
FrozenPandaz
approved these changes
Aug 30, 2023
jaysoo
force-pushed
the
feat/ensure-js-plugin
branch
from
5c660e0 to
2cf3440
Compare
Deprecates NPM and Core presets and show user a warning.
jaysoo
force-pushed
the
feat/ensure-js-plugin
branch
from
2cf3440 to
b97fa54
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
create-nx-workspaceand choosing either packaged-based or TS integrated monorepo, the user does not get@nx/jsplugin, which is wrong. In the future, code analysis for TS/JS files will be moved to@nx/jsfromnxcore, so this plugin has to exist. Furthermore, not installing@nx/jsautomatically means users cannot generate JS libs even though that was the whole point of choosing the TS/JS stack.This PR also deprecates the
CoreandEmptypresets. They have both been deprecated for over a year, and we just missed removing them. They are now scheduled for removal in Nx 18.Lastly, the
@nx/workspace:removechanges here is causing e2e test failure. Not sure how it passed originally, but this is fixed in this PR as well.