fix(bundling): add faux-ESM files so "import" in Node works with both named and default exports #18916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jaysoo
force-pushed
the
fix/rollup-node-import-esm
branch
from
7cc2f8d to
4d85aac
Compare
ndcunningham
approved these changes
Aug 30, 2023
jaysoo
force-pushed
the
fix/rollup-node-import-esm
branch
2 times, most recently
from
fa31e18 to
af9055c
Compare
… named and default exports
jaysoo
force-pushed
the
fix/rollup-node-import-esm
branch
from
af9055c to
1760b02
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address an issue with packaging dual formats with Rollup, where using
importin Node is causes issues.type: moduleis not specified (intentional), ESM files must have.mjsfile extensionexports.defaultbut Node usesexportsobject as the default export when using CJS in ESMThe updated e2e test has an example in Rollup to ensure dual format works correctly when using ESM in Node.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #18912