Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): sort objects when hashing them instead #18897

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

The external nodes of the project graph aren't guaranteed to be sorted but are hashed with JSON.stringify.

Expected Behavior

The external nodes of the project graph hashed agnostically of the order of its keys.

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested a review from a team as a code owner August 29, 2023 20:56
@FrozenPandaz FrozenPandaz requested a review from Cammisuli August 29, 2023 20:56
@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2023 2:03am

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) August 30, 2023 01:43
@FrozenPandaz FrozenPandaz merged commit db31f30 into nrwl:master Aug 30, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants