Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): pass projectNameAndRootFormat to js lib generator from nest lib generator #18891

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Aug 29, 2023

Chain the projectNameAndRootFormat option from @nx/nest:lib to @nx/js:lib, otherwise the generator errors out when as-provided is used. Also updates unit tests to use projectNameAndRootFormat: 'as-provided'.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner August 29, 2023 17:20
@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2023 6:24pm

@jaysoo jaysoo force-pushed the fix/nest-lib-generator branch from c42de84 to 91d47cb Compare August 29, 2023 17:25
…t lib generator

- Also updates unit tests to use `projectNameAndRootFormat: 'as-provided'`
@jaysoo jaysoo force-pushed the fix/nest-lib-generator branch from 91d47cb to fba4cb0 Compare August 29, 2023 17:55
Copy link
Contributor

@ndcunningham ndcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaysoo jaysoo self-assigned this Aug 29, 2023
@jaysoo jaysoo added the scope: node Issues related to Node, Express, NestJS support for Nx label Aug 29, 2023
@jaysoo jaysoo merged commit 74e5879 into nrwl:master Aug 29, 2023
@jaysoo jaysoo deleted the fix/nest-lib-generator branch August 29, 2023 18:35
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: node Issues related to Node, Express, NestJS support for Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants