Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-plugin): fix explicity obsolete type #18888

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

meeroslav
Copy link
Contributor

Current Behavior

Generated plugin fails on lint with Type string trivially inferred from a string literal, remove type annotation. due to @typescript-eslint/no-inferrable-types

Expected Behavior

Freshly generated plugin should not fail on lint

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Aug 29, 2023
@meeroslav meeroslav requested a review from a team as a code owner August 29, 2023 15:54
@meeroslav meeroslav requested a review from vsavkin August 29, 2023 15:54
@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2023 3:55pm

@meeroslav meeroslav requested a review from AgentEnder August 29, 2023 15:54
@AgentEnder AgentEnder merged commit 759c5e1 into nrwl:master Aug 29, 2023
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants