fix(nextjs): improve e2e test by reusing the project #18827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaysoo
requested changes
Aug 25, 2023
There was a problem hiding this comment.
Some tests won't pass with shared workspace (using beforeAll). Can we move those into a separate file or describe so they can have their own beforeAll scope?
Also we should separate into next-core and next-extensions. Storybook, component tests, styles, etc. can all go into next-extensions.
ndcunningham
force-pushed
the
fix/next-e2e-slow
branch
2 times, most recently
from
a325812 to
a03fcfe
Compare
ndcunningham
requested review from
FrozenPandaz,
a team,
vsavkin,
AgentEnder and
JamesHenry
as code owners
ndcunningham
force-pushed
the
fix/next-e2e-slow
branch
from
a03fcfe to
59b419d
Compare
jaysoo
approved these changes
Aug 25, 2023
ndcunningham
force-pushed
the
fix/next-e2e-slow
branch
2 times, most recently
from
a05cd39 to
f0b9931
Compare
ndcunningham
force-pushed
the
fix/next-e2e-slow
branch
from
f0b9931 to
72e42fc
Compare
FrozenPandaz
approved these changes
Aug 25, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done:
e2e/next/intoe2x/next-core/ande2e/next-extensionsnext-core/all tests that require an isolated workspace has been split into their own test file.e2e/next-core/ande2e/next-extensions/