feat(js): carry-over known build options (main, tsConfig, etc.) when running setup-build generator #18742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaysoo
requested review from
FrozenPandaz,
AgentEnder and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ndcunningham
approved these changes
Aug 21, 2023
jaysoo
force-pushed
the
feat/js-setup-build-enhancements
branch
from
74dd4ea to
e67f5db
Compare
jaysoo
force-pushed
the
feat/js-setup-build-enhancements
branch
from
e67f5db to
28aa943
Compare
jaysoo
force-pushed
the
feat/js-setup-build-enhancements
branch
from
28aa943 to
066d09c
Compare
jaysoo
force-pushed
the
feat/js-setup-build-enhancements
branch
from
066d09c to
5bf0972
Compare
…running setup-build generator
jaysoo
force-pushed
the
feat/js-setup-build-enhancements
branch
from
5bf0972 to
128f499
Compare
juristr
approved these changes
Aug 28, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows known build options to carry-over when running the @nx/js:setup-build generator. Options are:
This helps when converting from tsc to Rollup, for example, and the shared options should remain intact.
js-setup-build.mp4
Current Behavior
Existing build options are overridden
Expected Behavior
Known build options that work between our build/bundle executors should remain.
Related Issue(s)
Fixes #