fix(testing): make playwright nxE2EPreset options optional

[shaharkazaz]

Current Behavior

The options argument is optional and therefore the following should work:

nxE2EPreset(__filename)

When running the code you get:

TypeError: Cannot read properties of undefined (reading 'testDir')

Expected Behavior

nxE2EPreset(__filename) should work as expected.

Related Issue(s)

Fixes #

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 21, 2023 4:24pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0f24265. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• linux nx affected --target=e2e --base=7d4e2fec10530059366ab71f60f5d0cc5dfb6757 --head=0f24265f4ace86bdccbffb5eee5a0c87ed386475 --parallel=1
• linux nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• linux nx affected --target=build --base=7d4e2fec10530059366ab71f60f5d0cc5dfb6757 --head=0f24265f4ace86bdccbffb5eee5a0c87ed386475 --parallel=3
• linux nx affected --target=test --base=7d4e2fec10530059366ab71f60f5d0cc5dfb6757 --head=0f24265f4ace86bdccbffb5eee5a0c87ed386475 --parallel=1
• linux nx affected --target=lint --base=7d4e2fec10530059366ab71f60f5d0cc5dfb6757 --head=0f24265f4ace86bdccbffb5eee5a0c87ed386475 --parallel=3
• nx-cloud record -- nx format:check --base=7d4e2fec10530059366ab71f60f5d0cc5dfb6757 --head=0f24265f4ace86bdccbffb5eee5a0c87ed386475
• linux nx documentation --no-dte
• macos nx affected -t e2e-macos --parallel=1 --base=7d4e2fec10530059366ab71f60f5d0cc5dfb6757 --head=0f24265f4ace86bdccbffb5eee5a0c87ed386475

---

Sent with 💌 from NxCloud.

[shaharkazaz]

What's the scope here if not playwright? testing?

[barbados-clemens]

Thanks for the fix!
the scope is 'testing'

[shaharkazaz]

@barbados-clemens Ok. Do you want me to change the commit and force push to replace the message?

[barbados-clemens]

@barbados-clemens Ok. Do you want me to change the commit and force push to replace the message?

Yeah, ci checks the commit message formats, which is why it's failing currently.

[shaharkazaz]

@barbados-clemens sure np

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.