fix(core): ensure preinstall is only run once on repo #18671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FrozenPandaz
requested changes
Aug 17, 2023
| @@ -42,7 +43,9 @@ export function installPackagesTask( | |||
| cwd: join(tree.root, cwd), | |||
| stdio: process.env.NX_GENERATE_QUIET === 'true' ? 'ignore' : 'inherit', | |||
| }; | |||
| if (pmc.preInstall) { | |||
| // only run preinstall if install hasn't been run yet | |||
| // this only happens during CNW when preset is adding its dependencies | |||
There was a problem hiding this comment.
We can move this step out of devkit and into the new generator.
meeroslav
force-pushed
the
fix-install-task
branch
from
4cbe93b to
e7e494d
Compare
meeroslav
force-pushed
the
fix-install-task
branch
from
e7e494d to
7434a2a
Compare
FrozenPandaz
approved these changes
Aug 18, 2023
FrozenPandaz
pushed a commit
that referenced
this pull request
Aug 21, 2023
(cherry picked from commit adb39c4)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The preinstall step runs every time we call
installPackagesTask(on every generator and migration that added packages)Expected Behavior
The preinstall step should only run once, during the CNW to ensure install is run with the proper pm version.
Related Issue(s)
Fixes #