Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): use helper to determine project name and root directory in project generators #18615

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Aug 14, 2023

Updates the React plugin project generators (application, host, remote and library) to use the helper to determine the project name and root.

For more context on the changes, see: #18420

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Aug 14, 2023
@leosvelperez leosvelperez requested review from a team as code owners August 14, 2023 13:47
@vercel
Copy link

vercel bot commented Aug 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 3:26pm

@leosvelperez leosvelperez force-pushed the react/library-use-name-root-helper branch from abec886 to febb165 Compare August 14, 2023 14:08
@leosvelperez leosvelperez marked this pull request as draft August 16, 2023 08:54
@leosvelperez leosvelperez force-pushed the react/library-use-name-root-helper branch from febb165 to de31ddb Compare August 17, 2023 08:32
@leosvelperez leosvelperez changed the title feat(react): use helper to determine project name and root directory in library generator feat(react): use helper to determine project name and root directory in project generators Aug 17, 2023
@meeroslav meeroslav added the scope: react Issues related to React support for Nx label Aug 17, 2023
@leosvelperez leosvelperez force-pushed the react/library-use-name-root-helper branch from de31ddb to 4ac875c Compare August 17, 2023 15:32
@leosvelperez leosvelperez marked this pull request as ready for review August 17, 2023 15:33
@leosvelperez leosvelperez requested a review from a team as a code owner August 17, 2023 15:33
@leosvelperez leosvelperez force-pushed the react/library-use-name-root-helper branch from 5218e37 to 9949d8a Compare August 18, 2023 08:38
@leosvelperez leosvelperez force-pushed the react/library-use-name-root-helper branch from 9949d8a to 548b657 Compare August 18, 2023 12:48
Copy link
Contributor

@ndcunningham ndcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏿

@FrozenPandaz FrozenPandaz merged commit eb9caa1 into nrwl:master Aug 18, 2023
@leosvelperez leosvelperez deleted the react/library-use-name-root-helper branch August 18, 2023 17:52
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: react Issues related to React support for Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants