-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): use helper to determine project name and root directory in project generators #18615
Merged
FrozenPandaz
merged 5 commits into
nrwl:master
from
leosvelperez:react/library-use-name-root-helper
Aug 18, 2023
Merged
feat(react): use helper to determine project name and root directory in project generators #18615
FrozenPandaz
merged 5 commits into
nrwl:master
from
leosvelperez:react/library-use-name-root-helper
Aug 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leosvelperez
force-pushed
the
react/library-use-name-root-helper
branch
from
August 14, 2023 14:08
abec886
to
febb165
Compare
leosvelperez
force-pushed
the
react/library-use-name-root-helper
branch
from
August 17, 2023 08:32
febb165
to
de31ddb
Compare
leosvelperez
changed the title
feat(react): use helper to determine project name and root directory in library generator
feat(react): use helper to determine project name and root directory in project generators
Aug 17, 2023
leosvelperez
force-pushed
the
react/library-use-name-root-helper
branch
from
August 17, 2023 15:32
de31ddb
to
4ac875c
Compare
leosvelperez
force-pushed
the
react/library-use-name-root-helper
branch
from
August 18, 2023 08:38
5218e37
to
9949d8a
Compare
leosvelperez
force-pushed
the
react/library-use-name-root-helper
branch
from
August 18, 2023 12:48
9949d8a
to
548b657
Compare
ndcunningham
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏿
leosvelperez
force-pushed
the
react/library-use-name-root-helper
branch
from
August 18, 2023 15:20
548b657
to
b64543c
Compare
FrozenPandaz
approved these changes
Aug 18, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the React plugin project generators (application, host, remote and library) to use the helper to determine the project name and root.
For more context on the changes, see: #18420
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #