fix(linter): Normalize paths when in getSourceFilePath #18601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When running the linting rule
@nx/dependency-checks
for a project on a Windows machine, it doesn't fail even if the list of packages is not valid.The
projectPath
provided to the utility functiongetSourceFilePath
inpackages/eslint-plugin/src/utils/runtime-lint-utils.ts
is not normalized:Expected Behavior
The linting rule
@nx/dependency-checks
should work in the same way on Windows or UNIX paths.Fixes
To prevent future issues, I decided to make the
getSourceFilePath
compatible with any type of path instead of fixing the@nx/dependency-checks
code.Tests are covering that utility function
@nx/dependency-checks