-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(testing): improve error message for ct generators #18597
Merged
barbados-clemens
merged 2 commits into
nrwl:master
from
barbados-clemens:fix/warn-if-using-diff-ct-gen
Aug 23, 2023
Merged
fix(testing): improve error message for ct generators #18597
barbados-clemens
merged 2 commits into
nrwl:master
from
barbados-clemens:fix/warn-if-using-diff-ct-gen
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
barbados-clemens
added
the
scope: testing tools
Issues related to Cypress / Jest / Playwright / Vitest support in Nx
label
Aug 15, 2023
barbados-clemens
force-pushed
the
fix/warn-if-using-diff-ct-gen
branch
from
August 15, 2023 18:30
393c5f2
to
e22cb7a
Compare
barbados-clemens
force-pushed
the
fix/warn-if-using-diff-ct-gen
branch
from
August 15, 2023 20:55
e22cb7a
to
04ac330
Compare
4 tasks
meeroslav
reviewed
Aug 17, 2023
packages/angular/docs/cypress-component-configuration-examples.md
Outdated
Show resolved
Hide resolved
meeroslav
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs part looks ok
barbados-clemens
force-pushed
the
fix/warn-if-using-diff-ct-gen
branch
from
August 21, 2023 15:31
3a993af
to
1e4d313
Compare
leosvelperez
approved these changes
Aug 22, 2023
barbados-clemens
force-pushed
the
fix/warn-if-using-diff-ct-gen
branch
from
August 22, 2023 13:38
1e4d313
to
79e9c44
Compare
barbados-clemens
force-pushed
the
fix/warn-if-using-diff-ct-gen
branch
from
August 23, 2023 15:16
79e9c44
to
3d68aff
Compare
AgentEnder
approved these changes
Aug 23, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
when using the ct config generate from a different plugin than the desired framework the error message is the same causing confusing why it's not working
Expected Behavior
error message should be helpful in informing that a different plugin should be used when trying to use a plugin from a different framework than desired.
include some docs update about what is included with build
Related Issue(s)
Fixes #