Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): improve error message for ct generators #18597

Merged

Conversation

barbados-clemens
Copy link
Contributor

@barbados-clemens barbados-clemens commented Aug 11, 2023

Current Behavior

when using the ct config generate from a different plugin than the desired framework the error message is the same causing confusing why it's not working

Expected Behavior

error message should be helpful in informing that a different plugin should be used when trying to use a plugin from a different framework than desired.

include some docs update about what is included with build

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Aug 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2023 3:24pm

@barbados-clemens barbados-clemens self-assigned this Aug 15, 2023
@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Aug 15, 2023
@barbados-clemens barbados-clemens force-pushed the fix/warn-if-using-diff-ct-gen branch from 393c5f2 to e22cb7a Compare August 15, 2023 18:30
@barbados-clemens barbados-clemens force-pushed the fix/warn-if-using-diff-ct-gen branch from e22cb7a to 04ac330 Compare August 15, 2023 20:55
@barbados-clemens barbados-clemens marked this pull request as ready for review August 15, 2023 20:58
@barbados-clemens barbados-clemens requested a review from a team as a code owner August 15, 2023 20:58
@barbados-clemens barbados-clemens requested review from a team as code owners August 15, 2023 21:10
@barbados-clemens barbados-clemens linked an issue Aug 15, 2023 that may be closed by this pull request
4 tasks
Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs part looks ok

@barbados-clemens barbados-clemens merged commit f5d55e3 into nrwl:master Aug 23, 2023
@barbados-clemens barbados-clemens deleted the fix/warn-if-using-diff-ct-gen branch August 23, 2023 18:28
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress Component Testing (issues and guidelines)
4 participants